Skip to content

test(formatter/sort-imports): Update comments and tests#15896

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-20-test_formatter_sort-imports_update_comments_and_tests
Nov 20, 2025
Merged

test(formatter/sort-imports): Update comments and tests#15896
graphite-app[bot] merged 1 commit intomainfrom
11-20-test_formatter_sort-imports_update_comments_and_tests

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Nov 20, 2025 •
edited
Loading

Follow up of #15831

@leaysgur leaysgur requested a review from Dunqing as a code owner November 20, 2025 08:36
@github-actions github-actions bot added A-formatter Area - Formatter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 20, 2025
@leaysgur Graphite App
Copy link
Member Author

leaysgur commented Nov 20, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur mentioned this pull request Nov 20, 2025
Merged
6 tasks
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15896 will not alter performance

Comparing 11-20-test_formatter_sort-imports_update_comments_and_tests (f08a0a4) with 11-18-feat_formatter_sort-imports_support_options.groups (4953781)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@leaysgur leaysgur force-pushed the 11-20-test_formatter_sort-imports_update_comments_and_tests branch from 54efa0f to f08a0a4 Compare November 20, 2025 08:50
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
@leaysgur Graphite App
Copy link
Member Author

leaysgur commented Nov 20, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 11-18-feat_formatter_sort-imports_support_options.groups branch from 4953781 to 7818e22 Compare November 20, 2025 09:09
@graphite-app graphite-app bot force-pushed the 11-20-test_formatter_sort-imports_update_comments_and_tests branch from f08a0a4 to c230258 Compare November 20, 2025 09:09
Base automatically changed from 11-18-feat_formatter_sort-imports_support_options.groups to main November 20, 2025 09:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
@graphite-app graphite-app bot merged commit c230258 into main Nov 20, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-20-test_formatter_sort-imports_update_comments_and_tests branch November 20, 2025 09:15
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
@leaysgur
test(formatter/sort-imports): Update comments and tests (#15896)
e6db30b 
Follow up of #15831
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@leaysgur @taearls
test(formatter/sort-imports): Update comments and tests (oxc-project#…
43132a3 
…15896)

Follow up of oxc-project#15831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing approved these changes

Assignees

@Dunqing Dunqing

Labels

A-formatter Area - Formatter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leaysgur @Dunqing