Skip to content

ci(linter/plugins): lint apps/oxlint with oxlint#15887

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint
Nov 20, 2025
Merged

ci(linter/plugins): lint apps/oxlint with oxlint#15887
graphite-app[bot] merged 1 commit intomainfrom
11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 19, 2025

2nd try at #14573. Run oxlint on oxlint. Linter inception.

Copy link
Member Author

overlookmotel commented Nov 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot force-pushed the 11-19-refactor_linter_plugins_enable_ts_strictnullchecks_ branch 2 times, most recently from f27910c to 36780e3 Compare November 19, 2025 20:36
@graphite-app graphite-app bot force-pushed the 11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint branch from 48aa3b5 to c8047f1 Compare November 19, 2025 20:36
@overlookmotel overlookmotel force-pushed the 11-19-refactor_linter_plugins_enable_ts_strictnullchecks_ branch from 36780e3 to 4231c2a Compare November 19, 2025 22:05
@overlookmotel overlookmotel force-pushed the 11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint branch from c8047f1 to 168a7c1 Compare November 19, 2025 22:05
@overlookmotel overlookmotel changed the base branch from 11-19-refactor_linter_plugins_enable_ts_strictnullchecks_ to graphite-base/15887 November 19, 2025 22:44
@overlookmotel overlookmotel force-pushed the 11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint branch from 168a7c1 to 3e09979 Compare November 19, 2025 22:44
@overlookmotel overlookmotel changed the base branch from graphite-base/15887 to 11-19-test_linter_plugins_rename_dirs_in_nested_tests November 19, 2025 22:44
@github-actions github-actions bot added the A-linter-plugins Area - Linter JS plugins label Nov 19, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 19, 2025 22:56
@overlookmotel
Copy link
Member Author

What??? node --run lint passes locally, but in CI it's failing.

https://github.com/oxc-project/oxc/actions/runs/19518845304/job/55877473884?pr=15887#step:8:20

typescript-eslint(no-redundant-type-constituents): 'ESTree.Program' is an 'error' type that acts as 'any' and overrides all other types in this union type.

ESTree.Program is not an error type!

@overlookmotel
Copy link
Member Author

overlookmotel commented Nov 19, 2025

Figured it out. plugin.ts files in Oxlint's tests (which we want to lint) import types from dist/index.d.ts.

Type-aware rules require the types from that file, but the file's not present until TSDown builds apps/oxlint.

Have added that to the lint CI task, and now it works.

@overlookmotel overlookmotel force-pushed the 11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint branch from 94b71ad to b24574d Compare November 20, 2025 13:48
@overlookmotel overlookmotel force-pushed the 11-19-test_linter_plugins_rename_dirs_in_nested_tests branch from 65e0f91 to 78945ca Compare November 20, 2025 13:48
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
Copy link
Contributor

camc314 commented Nov 20, 2025

Merge activity

  • Nov 20, 3:50 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 20, 3:50 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 20, 4:20 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 20, 4:20 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Nov 20, 4:21 PM UTC: Merged by the Graphite merge queue.

2nd try at #14573. Run oxlint on oxlint. Linter inception.
graphite-app bot pushed a commit that referenced this pull request Nov 20, 2025
Rename the directories containing files to lint in the nested config tests from `nested` to `files`, to match the rest, and only lint the `files` directories.

I don't think this has any effect on the operation of the tests, but makes it easier to lint these directories as part of the repo (#15887).

This also removes the need for `overrideFiles` property in `testFixture` function's options, so remove it.
@graphite-app graphite-app bot force-pushed the 11-19-test_linter_plugins_rename_dirs_in_nested_tests branch from 78945ca to 6ce2f7a Compare November 20, 2025 15:53
@graphite-app graphite-app bot force-pushed the 11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint branch from b24574d to 1020373 Compare November 20, 2025 15:54
Base automatically changed from 11-19-test_linter_plugins_rename_dirs_in_nested_tests to main November 20, 2025 15:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
@graphite-app graphite-app bot merged commit 1020373 into main Nov 20, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint branch November 20, 2025 16:21
@overlookmotel overlookmotel removed the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
Rename the directories containing files to lint in the nested config tests from `nested` to `files`, to match the rest, and only lint the `files` directories.

I don't think this has any effect on the operation of the tests, but makes it easier to lint these directories as part of the repo (#15887).

This also removes the need for `overrideFiles` property in `testFixture` function's options, so remove it.
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
2nd try at #14573. Run oxlint on oxlint. Linter inception.
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Rename the directories containing files to lint in the nested config tests from `nested` to `files`, to match the rest, and only lint the `files` directories.

I don't think this has any effect on the operation of the tests, but makes it easier to lint these directories as part of the repo (oxc-project#15887).

This also removes the need for `overrideFiles` property in `testFixture` function's options, so remove it.
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants