fix(tools): make just ast work on Windows#15704
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the just ast command to work correctly on Windows by updating the shell syntax to be PowerShell-compatible. The issue was that PowerShell doesn't support ( ... ) for command groupings.
Key changes:
- Updated command grouping syntax from
( ... )to{ ... }in theastrecipe - Added semicolon as command terminator within the braces
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I don't know about Windows, but it works on Mac. Don't want to bother anyone with reviewing, so merging. |
Merge activity
|
According to Claude, `just ast` in its current form will not work on Windows, as PowerShell does not support `( ... )` for command groupings. Switch to `{ ... }`.
This script was added in #15565. Copilot writes it, Claude critiques it!
66a028d to
e49d428
Compare
According to Claude, `just ast` in its current form will not work on Windows, as PowerShell does not support `( ... )` for command groupings. Switch to `{ ... }`.
This script was added in oxc-project#15565. Copilot writes it, Claude critiques it!
According to Claude,
just astin its current form will not work on Windows, as PowerShell does not support( ... )for command groupings. Switch to{ ... }.This script was added in #15565. Copilot writes it, Claude critiques it!