test(linter): add e2e test exercising many config options#15660
Closed
test(linter): add e2e test exercising many config options#15660
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
5aded22 to
f86760b
Compare
6dbfe29 to
69d9c8f
Compare
14ae066 to
53c3493
Compare
f86760b to
f3fd330
Compare
f3fd330 to
55e598d
Compare
53c3493 to
c199e38
Compare
55e598d to
57b21e0
Compare
connorshea
reviewed
Nov 17, 2025
Comment on lines
+792
to
+798
| x typescript-eslint(return-await): Returning an awaited promise is not allowed in this context. | ||
| ,-[config-options-test.ts:299:10] | ||
| 298 | // Should pass | ||
| 299 | return await Promise.resolve(42); | ||
| : ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| 300 | | ||
| `---- |
Member
There was a problem hiding this comment.
looks like this fails in the snap?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is blocked on updating to tsgolint to the version after 0.6.0.
This adds an end-to-end test for tsgolint that exercises most of the configuration options supported by rules currently. This should be a useful way of ensuring we don't regress this functionality somehow (and be an early warning if something goes wrong in tsgolint).