Skip to content

docs(linter): Update node/no-process-env rule to have proper config docs.#15525

Merged
graphite-app[bot] merged 1 commit intomainfrom
no-process-env-config
Nov 10, 2025
Merged

docs(linter): Update node/no-process-env rule to have proper config docs.#15525
graphite-app[bot] merged 1 commit intomainfrom
no-process-env-config

Conversation

@connorshea
Copy link
Member

@connorshea connorshea commented Nov 9, 2025

Part of #14743.

Extracted from #15234.

Generated docs:

## Configuration

This rule accepts a configuration object with the following properties:

### allowedVariables

type: `string[]`

default: `[]`

Variable names which are allowed to be accessed on `process.env`.

Copilot AI review requested due to automatic review settings November 9, 2025 17:28
@connorshea connorshea requested a review from camc314 as a code owner November 9, 2025 17:28
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Nov 9, 2025
Copilot AI reviewed Nov 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the no_process_env rule configuration to use better naming and improve code clarity.

  • Renamed ConfigElement0 to the more descriptive NoProcessEnvConfig
  • Added documentation for the allowed_variables field
  • Updated all references to use the new struct name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 9, 2025

CodSpeed Performance Report

Merging #15525 will not alter performance

Comparing no-process-env-config (c52b45c) with main (f1efc63)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 10, 2025
@camc314 camc314 self-assigned this Nov 10, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Nov 10, 2025 •
edited by graphite-app bot
Loading

Merge activity

@connorshea
docs(linter): Update node/no-process-env rule to have proper config d…
e2f7db4 
…ocs. (#15525)

Part of #14743.

Extracted from #15234.

Generated docs:

```md
## Configuration

This rule accepts a configuration object with the following properties:

### allowedVariables

type: `string[]`

default: `[]`

Variable names which are allowed to be accessed on `process.env`.
```
@graphite-app graphite-app bot force-pushed the no-process-env-config branch from c52b45c to e2f7db4 Compare November 10, 2025 09:14
@graphite-app graphite-app bot merged commit e2f7db4 into main Nov 10, 2025
20 checks passed
@graphite-app graphite-app bot deleted the no-process-env-config branch November 10, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connorshea @camc314