refactor(language_server): move get_code_actions_or_commands to Tool trait#15490
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 8, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
75c0959 to
bef4ce9
Compare
Member
Author
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the get_code_actions_or_commands method by moving it from a ServerLinter-specific implementation to the Tool trait, making it available for polymorphic use across different tool types (linter, formatter, etc.).
- Adds
get_code_actions_or_commandsas a trait method in theTooltrait with a default implementation - Moves the ServerLinter's existing implementation from the
impl ServerLinterblock to theimpl Tool for ServerLinterblock - Updates imports in tester.rs to include the
Tooltrait
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_language_server/src/tool.rs | Adds new trait method get_code_actions_or_commands with default implementation and required type imports |
| crates/oxc_language_server/src/linter/tester.rs | Adds Tool trait import to support trait method usage |
| crates/oxc_language_server/src/linter/server_linter.rs | Moves get_code_actions_or_commands from impl block to trait implementation without logic changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bef4ce9 to
79e6842
Compare
This was referenced Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.