Skip to content

feat(parser): show allowed modifiers in invalid modifier error messages#15442

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages
Nov 8, 2025
Merged

feat(parser): show allowed modifiers in invalid modifier error messages#15442
graphite-app[bot] merged 1 commit intomainfrom
11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 7, 2025 •
edited
Loading

Add allowed modifiers for that context so that it's easier to understand what is wrong.

This was referenced Nov 7, 2025
Merged
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Nov 7, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Nov 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15442 will not alter performance

Comparing 11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages (83f9de7) with main (b7e3849)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on 11-05-feat_parser_add_ts1274_error (aa2a4cb) during the generation of this report, so main (b7e3849) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sapphi-red sapphi-red force-pushed the 11-05-feat_parser_add_ts1274_error branch from 3619c92 to 4e16ccf Compare November 7, 2025 17:58
@sapphi-red sapphi-red force-pushed the 11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages branch from e5c4413 to 3e212bb Compare November 7, 2025 17:58
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 7, 2025
@sapphi-red sapphi-red force-pushed the 11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages branch from 3e212bb to 7442cfc Compare November 7, 2025 18:12
@sapphi-red sapphi-red force-pushed the 11-05-feat_parser_add_ts1274_error branch from 4e16ccf to 59a0dcf Compare November 7, 2025 18:12
@sapphi-red sapphi-red requested review from Boshen and Dunqing and removed request for Dunqing November 7, 2025 18:17
@sapphi-red sapphi-red marked this pull request as ready for review November 7, 2025 18:17
@graphite-app graphite-app bot force-pushed the 11-05-feat_parser_add_ts1274_error branch from 59a0dcf to d3aa993 Compare November 8, 2025 04:34
@graphite-app graphite-app bot requested a review from Dunqing as a code owner November 8, 2025 04:34
@graphite-app graphite-app bot force-pushed the 11-05-feat_parser_add_ts1274_error branch from d3aa993 to aa2a4cb Compare November 8, 2025 04:35
@graphite-app graphite-app bot force-pushed the 11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages branch from 7442cfc to 83f9de7 Compare November 8, 2025 04:35
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 8, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Nov 8, 2025 •
edited by graphite-app bot
Loading

Merge activity

@sapphi-red
feat(parser): show allowed modifiers in invalid modifier error messag…
73f9e29 
…es (#15442)

Add allowed modifiers for that context so that it's easier to understand what is wrong.
@graphite-app graphite-app bot force-pushed the 11-05-feat_parser_add_ts1274_error branch from aa2a4cb to 5616ad5 Compare November 8, 2025 06:46
@graphite-app graphite-app bot force-pushed the 11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages branch from 83f9de7 to 73f9e29 Compare November 8, 2025 06:47
Base automatically changed from 11-05-feat_parser_add_ts1274_error to main November 8, 2025 06:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 8, 2025
@graphite-app graphite-app bot merged commit 73f9e29 into main Nov 8, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-05-feat_parser_show_allowed_modifiers_in_invalid_modifier_error_messages branch November 8, 2025 06:53
@Boshen Boshen mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

@Dunqing Dunqing Awaiting requested review from Dunqing

Assignees

@Boshen Boshen

Labels

A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Boshen