Skip to content

fix(language_server): fail gracefully when tsgolint executable not found#15436

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-07-fix_language_server_fail_gracefully_when_tsgolint_executable_not_found
Nov 7, 2025
Merged

fix(language_server): fail gracefully when tsgolint executable not found#15436
graphite-app[bot] merged 1 commit intomainfrom
c/11-07-fix_language_server_fail_gracefully_when_tsgolint_executable_not_found

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 7, 2025 •
edited
Loading

fixes #15421

@camc314 camc314 marked this pull request as ready for review November 7, 2025 15:10
@camc314 camc314 requested a review from Sysix as a code owner November 7, 2025 15:10
Copilot AI review requested due to automatic review settings November 7, 2025 15:10
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Nov 7, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 7, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Nov 7, 2025
Copilot AI reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds error handling for type-aware linting initialization with a fallback mechanism. When building a LintRunner with type-aware linting fails, the code now gracefully falls back to non-type-aware linting instead of panicking.

  • Added error handling wrapper around LintRunnerBuilder::build() with match expression
  • Implemented fallback logic that recreates the runner without type-aware linting on failure
  • Added warn log import to report initialization failures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app[bot]
graphite-app bot reviewed Nov 7, 2025
View reviewed changes
Sysix
Sysix requested changes Nov 7, 2025
View reviewed changes
Copy link
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tsConfigPath configuration should still be applied. (see comment)
Not sure how a test for this scenario would look like. 🤔

@camc314 camc314 force-pushed the c/11-07-fix_language_server_fail_gracefully_when_tsgolint_executable_not_found branch from 9fb8b54 to 7f74628 Compare November 7, 2025 15:25
@camc314 camc314 requested a review from Sysix November 7, 2025 15:26
@camc314 camc314 force-pushed the c/11-07-fix_language_server_fail_gracefully_when_tsgolint_executable_not_found branch from 7f74628 to 21f5351 Compare November 7, 2025 15:26
Sysix
Sysix approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Sysix Graphite App
Copy link
Member

Sysix commented Nov 7, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 7, 3:32 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 7, 7:12 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 7, 7:12 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 7, 7:19 PM UTC: Merged by the Graphite merge queue.

Copilot AI reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@camc314 camc314 mentioned this pull request Nov 7, 2025
Closed
@Sysix Sysix removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Sysix
Copy link
Member

Sysix commented Nov 7, 2025

@camc314 graphite does not like me :( can you try to start :D?

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@graphite-app graphite-app bot force-pushed the c/11-07-fix_language_server_fail_gracefully_when_tsgolint_executable_not_found branch from 21f5351 to ecf2f7b Compare November 7, 2025 19:13
@graphite-app graphite-app bot merged commit ecf2f7b into main Nov 7, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/11-07-fix_language_server_fail_gracefully_when_tsgolint_executable_not_found branch November 7, 2025 19:19
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Boshen Boshen mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Copilot code review Copilot Copilot left review comments

@Sysix Sysix Sysix approved these changes

Assignees

@Sysix Sysix

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: VSCode extension v1.26.0 won't start: "Failed to find tsgolint executable"

3 participants

@camc314 @Sysix