Skip to content

perf(formatter): use CodeBuffer's built-in print_indent to print indentation#15406

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-07-perf_formatter_use_codebuffer_s_built-in_print_indent_to_print_indentation
Nov 7, 2025
Merged

perf(formatter): use CodeBuffer's built-in print_indent to print indentation#15406
graphite-app[bot] merged 1 commit intomainfrom
11-07-perf_formatter_use_codebuffer_s_built-in_print_indent_to_print_indentation

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 7, 2025 •
edited
Loading

I forgot this APi in #14752

@github-actions github-actions bot added A-formatter Area - Formatter C-performance Category - Solution not expected to change functional behavior, only performance labels Nov 7, 2025
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Nov 7, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Nov 7, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #15406 will not alter performance

Comparing 11-07-perf_formatter_use_codebuffer_s_built-in_print_indent_to_print_indentation (eb67f92) with 11-07-perf_formatter_check_the_text_to_see_whether_it_has_multiple_lines_by_width (6f663ea)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing marked this pull request as ready for review November 7, 2025 03:46
@Dunqing Dunqing requested a review from leaysgur November 7, 2025 03:52
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@leaysgur Graphite App
Copy link
Member

leaysgur commented Nov 7, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 11-07-perf_formatter_check_the_text_to_see_whether_it_has_multiple_lines_by_width branch from 6f663ea to 681607b Compare November 7, 2025 04:22
@graphite-app graphite-app bot force-pushed the 11-07-perf_formatter_use_codebuffer_s_built-in_print_indent_to_print_indentation branch from eb67f92 to 2515045 Compare November 7, 2025 04:22
Base automatically changed from 11-07-perf_formatter_check_the_text_to_see_whether_it_has_multiple_lines_by_width to main November 7, 2025 04:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@graphite-app graphite-app bot merged commit 2515045 into main Nov 7, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-07-perf_formatter_use_codebuffer_s_built-in_print_indent_to_print_indentation branch November 7, 2025 04:29
@Boshen Boshen mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leaysgur leaysgur Awaiting requested review from leaysgur

Assignees

@leaysgur leaysgur

Labels

A-formatter Area - Formatter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing @leaysgur