perf(formatter): optimize FormatElement::Token printing#15365
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 7, 2025
Merged
Conversation
Member
Author
CodSpeed Performance ReportMerging #15365 will not alter performanceComparing Summary
Footnotes
|
d08415c to
c825305
Compare
f3449e0 to
073c27b
Compare
This was referenced Nov 6, 2025
073c27b to
c18f154
Compare
c825305 to
e4faa85
Compare
This was referenced Nov 6, 2025
Contributor
Merge activity
|
`FormatElement::Token` is ASCII-only and does not contain line breaks or tab characters, so we can skip the `\n` check and simplify the logic of getting `FormatElement::Token` length
e4faa85 to
f90e515
Compare
c18f154 to
98c9234
Compare
Base automatically changed from
11-06-refactor_formatter_rename_formatelement_statictext_and_formatelement_dynamictext_to_formatelement_token_and_formatelement_text
to
main
November 7, 2025 01:26
This was referenced Nov 7, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

FormatElement::Tokenis ASCII-only and does not contain line breaks or tab characters, so we can skip the\ncheck and simplify the logic of gettingFormatElement::Tokenlength