Skip to content

fix(lang-server): improve logging in failure case for tsgolint#15299

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-05-fix_lang-server_improve_logging_in_failure_case_for_tsgolint
Nov 7, 2025
Merged

fix(lang-server): improve logging in failure case for tsgolint#15299
graphite-app[bot] merged 1 commit intomainfrom
c/11-05-fix_lang-server_improve_logging_in_failure_case_for_tsgolint

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 5, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review November 5, 2025 09:19
@camc314 camc314 requested a review from Sysix as a code owner November 5, 2025 09:19
Copilot AI review requested due to automatic review settings November 5, 2025 09:19
@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-bug Category - Bug labels Nov 5, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 5, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates error handling for type-aware linting by propagating errors instead of silently ignoring them. The run_source method now returns a Result type, allowing errors from type-aware linting to be properly handled.

  • Changed run_source return type from Vec<Message> to Result<Vec<Message>, String>
  • Updated error handling to use the ? operator for propagating errors
  • Added error logging when type-aware linting fails

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_linter/src/lint_runner.rs Changed run_source to return Result and propagate type-aware linting errors using ? operator
crates/oxc_language_server/src/linter/isolated_lint_handler.rs Updated to handle the new Result return type with pattern matching and error logging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2025 •
edited
Loading

Merge activity

  • Nov 5, 9:21 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 5, 9:21 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 7, 6:37 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 7, 6:37 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 7, 6:42 PM UTC: Merged by the Graphite merge queue.

graphite-app[bot]
graphite-app bot reviewed Nov 5, 2025
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15299 will not alter performance

Comparing c/11-05-fix_lang-server_improve_logging_in_failure_case_for_tsgolint (1930e80) with main (b1d3e00)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This was referenced Nov 5, 2025
Merged
Merged
@camc314 camc314 force-pushed the c/11-05-fix_lang-server_improve_logging_in_failure_case_for_tsgolint branch 2 times, most recently from 2cdb827 to 1930e80 Compare November 6, 2025 14:15
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@graphite-app graphite-app bot force-pushed the c/11-05-fix_lang-server_improve_logging_in_failure_case_for_tsgolint branch from 1930e80 to 3c8d3a7 Compare November 7, 2025 18:38
@graphite-app graphite-app bot merged commit 3c8d3a7 into main Nov 7, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/11-05-fix_lang-server_improve_logging_in_failure_case_for_tsgolint branch November 7, 2025 18:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Boshen Boshen mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Copilot code review Copilot Copilot left review comments

@Sysix Sysix Sysix approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camc314 @Sysix