feat(editor): support oxc.fmt.configPath configuration#14639
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 17, 2025
Merged
Conversation
Member
Author
049aef7 to
be35392
Compare
bbcabc2 to
d0aba11
Compare
be35392 to
9a2df8d
Compare
d0aba11 to
4995f5c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the oxc.fmt.configPath configuration option, allowing users to specify a custom path to an oxfmt configuration file for formatting operations. When set to null, the formatter defaults to using .oxfmtrc.json at the workspace root.
Key changes:
- Added
oxc.fmt.configPathconfiguration option to VS Code extension settings - Implemented configuration handling in
WorkspaceConfigclass with getter/setter methods - Added E2E test demonstrating formatting with a custom config file path
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/package.json | Adds oxc.fmt.configPath configuration schema with string or null type |
| editors/vscode/client/WorkspaceConfig.ts | Implements config path property, getter/setter methods, and language server serialization |
| editors/vscode/tests/WorkspaceConfig.spec.ts | Adds test coverage for the new config path property |
| editors/vscode/tests/e2e_server.spec.ts | Adds E2E test and teardown for formatting with custom config path |
| editors/vscode/README.md | Documents the new configuration option |
| editors/vscode/fixtures/formatting_with_config/formatting.ts | Test fixture file for formatting test |
| editors/vscode/fixtures/formatting_with_config/formatter.json | Test config file with semicolons setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9a2df8d to
426f7e5
Compare
55fd06f to
b4880dc
Compare
b4880dc to
65faf92
Compare
camc314
approved these changes
Oct 17, 2025
Contributor
Merge activity
|
Now, the VSCode editor supports `oxc.fmt.configPath` to communicate with the server. Other Editors could use it already, waited for the "watch" feature to implement it in VSCode :)
65faf92 to
8b322d4
Compare
This was referenced Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the VSCode editor supports
oxc.fmt.configPathto communicate with the server.Other Editors could use it already, waited for the "watch" feature to implement it in VSCode :)