Skip to content

chore(parser): enable oxlint#14571

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/10-13-chore_parser_enable_oxlint
Oct 14, 2025
Merged

chore(parser): enable oxlint#14571
graphite-app[bot] merged 1 commit intomainfrom
c/10-13-chore_parser_enable_oxlint

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 13, 2025

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 13, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 13, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 13, 2025
Merged
Merged
Closed
@camc314 camc314 marked this pull request as ready for review October 13, 2025 21:35
overlookmotel
overlookmotel approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One query below. But that maybe reflects a mistake in jest/no-export rule - side issue.

@graphite-app graphite-app bot changed the base branch from c/10-13-chore_playground_enable_oxlint to graphite-base/14571 October 14, 2025 11:18
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 14, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Oct 14, 11:20 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 14, 11:20 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Oct 14, 11:24 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Oct 14, 1:20 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 14, 1:25 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Oct 14, 1:30 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/14571 to main October 14, 2025 11:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025
@overlookmotel
Copy link
Member

overlookmotel commented Oct 14, 2025

@camc314 Graphite seems to have had a brain fart.

Copilot AI review requested due to automatic review settings October 14, 2025 13:19
@camc314 camc314 force-pushed the c/10-13-chore_parser_enable_oxlint branch from eff4a31 to 27e5d76 Compare October 14, 2025 13:19
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025
Copilot AI reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables oxlint for the napi/parser directory by removing it from the ignore list in the oxlint configuration and adding necessary lint disable comments to suppress specific warnings.

  • Removes napi/parser from the oxlint ignore list in oxlintrc.json
  • Adds selective lint disable comments for legitimate cases where lint rules need to be bypassed

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
oxlintrc.json Removes napi/parser from the oxlint ignore list to enable linting
napi/parser/test/visit.test.ts Adds eslint disable comment for vitest/expect-expect rule
napi/parser/test/typescript-make-units-from-test.ts Adds oxlint disable comment for jest/no-export rule
napi/parser/src-js/visit/visitor.js Adds oxlint disable comment for typescript/no-implied-eval rule
napi/parser/src-js/raw-transfer/node-array.js Adds oxlint disable comment for typescript/unbound-method rule

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graphite-app graphite-app bot force-pushed the c/10-13-chore_parser_enable_oxlint branch from 27e5d76 to 1cc7ee9 Compare October 14, 2025 13:25
@graphite-app graphite-app bot merged commit 1cc7ee9 into main Oct 14, 2025
18 checks passed
@graphite-app graphite-app bot deleted the c/10-13-chore_parser_enable_oxlint branch October 14, 2025 13:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camc314 @overlookmotel