Skip to content

refactor(ast_tools/raw_transfer): remove support for flattening enums#14336

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-04-refactor_ast_tools_raw_transfer_remove_support_for_flattening_enums
Oct 4, 2025
Merged

refactor(ast_tools/raw_transfer): remove support for flattening enums#14336
graphite-app[bot] merged 1 commit intomainfrom
10-04-refactor_ast_tools_raw_transfer_remove_support_for_flattening_enums

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 4, 2025 •
edited
Loading

Remove support for flattening enums in raw transfer codegen. We don't use this any more.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 4, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 4, 2025
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review October 4, 2025 16:57
Copilot AI review requested due to automatic review settings October 4, 2025 16:57
Copilot AI reviewed Oct 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes support for flattening enums in the raw transfer code generator, simplifying the logic to only support struct flattening. The change reduces complexity in the deserialization generator by eliminating unused enum flattening functionality.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Oct 4, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2025 •
edited
Loading

Merge activity

@overlookmotel
refactor(ast_tools/raw_transfer): remove support for flattening enums (…
5f328fe 
…#14336)

Remove support for flattening enums in raw transfer codegen. We don't use this any more.
@graphite-app graphite-app bot force-pushed the 10-04-refactor_ast_tools_raw_transfer_remove_support_for_flattening_enums branch from 5e2f923 to 5f328fe Compare October 4, 2025 17:03
@graphite-app graphite-app bot merged commit 5f328fe into main Oct 4, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 10-04-refactor_ast_tools_raw_transfer_remove_support_for_flattening_enums branch October 4, 2025 17:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel