Skip to content

fix(language_server): fix placement "ignore this rule for this file" in vue files with CRLF Line ending#14214

Closed
Sysix wants to merge 1 commit intomainfrom
09-28-fix_editor_fix_placement_ignore_this_rule_for_this_file_in_vue_files_with_crlf_line_ending
Closed

fix(language_server): fix placement "ignore this rule for this file" in vue files with CRLF Line ending#14214
Sysix wants to merge 1 commit intomainfrom
09-28-fix_editor_fix_placement_ignore_this_rule_for_this_file_in_vue_files_with_crlf_line_ending

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Sep 28, 2025 •
edited
Loading

@Sysix Graphite App
Copy link
Member Author

Sysix commented Sep 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Sep 28, 2025
@Sysix Sysix marked this pull request as ready for review September 28, 2025 16:37
@Sysix Sysix requested a review from camc314 as a code owner September 28, 2025 16:37
Copilot AI review requested due to automatic review settings September 28, 2025 16:37
Copilot AI reviewed Sep 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the placement of "ignore this rule for this file" comments in Vue files that use CRLF line endings. The fix ensures proper offset calculation when inserting linter disable comments after CRLF sequences.

  • Updates the disable_for_this_section function to handle both LF and CRLF line endings
  • Adds comprehensive test coverage for different line ending scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sysix Sysix changed the title fix(editor): fix placement "ignore this rule for this file" in vue files with CRLF Line ending fix(language_server): fix placement "ignore this rule for this file" in vue files with CRLF Line ending Sep 28, 2025
@Sysix Sysix marked this pull request as draft September 28, 2025 16:39
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #14214 will not alter performance

Comparing 09-28-fix_editor_fix_placement_ignore_this_rule_for_this_file_in_vue_files_with_crlf_line_ending (5728ced) with main (e37c435)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Sysix Sysix force-pushed the 09-28-fix_editor_fix_placement_ignore_this_rule_for_this_file_in_vue_files_with_crlf_line_ending branch from 623fa77 to fe04110 Compare September 28, 2025 16:53
@Sysix Sysix force-pushed the 09-28-fix_editor_fix_placement_ignore_this_rule_for_this_file_in_vue_files_with_crlf_line_ending branch from fe04110 to 5728ced Compare September 28, 2025 16:57
@Sysix Sysix marked this pull request as ready for review September 28, 2025 17:01
@camc314
Copy link
Contributor

camc314 commented Sep 29, 2025

apologies Sysix, I merged shulaoda's PR first

@camc314 camc314 closed this Sep 29, 2025
@Sysix Sysix mentioned this pull request Sep 29, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Sep 29, 2025
@Sysix
test(linter): add test for disable_for_this_section fix (#14240)
55ebb8b 
tests from #14214

got closed because #14228 got merged first
@Sysix Sysix deleted the 09-28-fix_editor_fix_placement_ignore_this_rule_for_this_file_in_vue_files_with_crlf_line_ending branch October 3, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314