test(linter): set CWD for tests by overlookmotel · Pull Request #13722 · oxc-project/oxc

overlookmotel · 2025-09-12T08:44:58Z

#13723 turns apps/oxlint into a NAPI package, and moves all the files from napi/oxlint into apps/oxlint.

These files include the test directory, which includes tests for JS plugins. This causes problems with 3 of the existing oxlint Rust tests, which run with cwd as apps/oxlint and no config file specified, because they pick up config files in the JS test fixtures. These config files include JS plugins, which oxlint's Rust tests can't handle because they're run without an ExternalLinter.

This PR works around this problem by setting cwd to apps/oxlint/fixtures for these 3 tests.

I'm not sure if this is a reasonable way to solve the problem.

overlookmotel · 2025-09-12T08:45:16Z

feat(linter): convert oxlint to NAPI app #13723
test(linter): set CWD for tests #13722 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR fixes test failures caused by moving files from napi/oxlint into apps/oxlint as part of making apps/oxlint a NAPI package. The issue was that three Rust tests were picking up JS plugin configuration files from test fixtures, causing failures since Rust tests don't support external linters.

Set working directory to fixtures for three affected tests to avoid config file conflicts
Updated test paths to be relative to the new working directory
Updated snapshot files to reflect the new working directory

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
apps/oxlint/src/lint.rs	Modified three test functions to set CWD to "fixtures" and adjusted file paths accordingly
apps/oxlint/src/snapshots/fixtures_-A all --print-config@oxlint.snap	Updated snapshot to show new working directory
apps/oxlint/src/snapshots/fixtures_--tsconfig oxc__tsconfig.json@oxlint.snap	Updated snapshot to reflect new working directory and error message path

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

camc314 · 2025-09-12T08:57:58Z

Merge activity

Sep 12, 8:57 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 12, 8:58 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 12, 9:03 AM UTC: Merged by the Graphite merge queue.

#13723 turns `apps/oxlint` into a NAPI package, and moves all the files from `napi/oxlint` into `apps/oxlint`. These files include the `test` directory, which includes tests for JS plugins. This causes problems with 3 of the existing `oxlint` Rust tests, which run with `cwd` as `apps/oxlint` and no config file specified, because they pick up config files in the JS test fixtures. These config files include JS plugins, which `oxlint`'s Rust tests can't handle because they're run without an `ExternalLinter`. This PR works around this problem by setting `cwd` to `apps/oxlint/fixtures` for these 3 tests. I'm not sure if this is a reasonable way to solve the problem.

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

Convert `oxlint` to a NAPI package. This PR: 1. Moves files from `napi/oxlint` into `apps/oxlint`. 2. Converts `oxlint` into a NAPI package. 3. Alters the [release workflow](https://github.com/oxc-project/oxc/pull/13723/files#diff-80cb497c859bbaf7756da6ced2bca3d31933affc96102983eee1ad7d4bcc60fd) and [script](https://github.com/oxc-project/oxc/pull/13723/files#diff-4c4b7045c68805aeeae7c0af94cf7cf7487cb0403496da974a6a23accdc457d0) for building `oxlint` packages. Most of necessary code modifications and refactoring was done in previous PRs (#13701, #13712, #13722, #13745), so this PR only includes changes necessary for packaging as NAPI. I've done my best to update release workflow, but am mostly "flying blind" without ability to test it, so very likely there are mistakes. A few notes and oddities: * I've kept the `oxlint` NPM package as CommonJS. We could probably switch to ESM, but I thought it better to minimize the changes in this PR. * NAPI-RS creates `.node` files named with a `-msvc` postfix for Windows. The scripts here remove that postfix so that filename of `.node` files and NPM package names match for all platforms, for simplicity. * `tasks/website` has a dependency on `oxlint` as a normal library. This resulted in linker errors, so have had to put all the NAPI stuff behind `napi` cargo feature. Tests for `tasks/website` are run separately in CI, to avoid feature unification turning on the `napi` feature for `website`. I've made a few comments below for the parts which aren't fairly self-explanatory.

github-actions bot added A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Sep 12, 2025

overlookmotel mentioned this pull request Sep 12, 2025

feat(linter): convert oxlint to NAPI app #13723

Merged

overlookmotel marked this pull request as ready for review September 12, 2025 08:54

overlookmotel requested a review from camc314 as a code owner September 12, 2025 08:54

Copilot AI review requested due to automatic review settings September 12, 2025 08:54

Copilot AI reviewed Sep 12, 2025

View reviewed changes

overlookmotel assigned camc314 Sep 12, 2025

camc314 approved these changes Sep 12, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025

graphite-app bot force-pushed the 09-12-test_linter_set_cwd_for_tests branch from 0149a7e to fb2d087 Compare September 12, 2025 08:58

graphite-app bot merged commit fb2d087 into main Sep 12, 2025
17 checks passed

graphite-app bot deleted the 09-12-test_linter_set_cwd_for_tests branch September 12, 2025 09:03

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(linter): set CWD for tests#13722

test(linter): set CWD for tests#13722
graphite-app[bot] merged 1 commit intomainfrom
09-12-test_linter_set_cwd_for_tests

overlookmotel commented Sep 12, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 commented Sep 12, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

overlookmotel commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

camc314 commented Sep 12, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Sep 12, 2025 •

edited

Loading

overlookmotel commented Sep 12, 2025 •

edited

Loading

camc314 commented Sep 12, 2025 •

edited by graphite-app bot

Loading