Skip to content

refactor(ast_tools): remove dead code from raw transfer codegen#13594

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-08-refactor_ast_tools_remove_dead_code_from_raw_transfer_codegen
Sep 8, 2025
Merged

refactor(ast_tools): remove dead code from raw transfer codegen#13594
graphite-app[bot] merged 1 commit intomainfrom
09-08-refactor_ast_tools_remove_dead_code_from_raw_transfer_codegen

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 8, 2025 •
edited
Loading

Follow-on after #13432. That PR removed usage of constructor_names, so it's now dead code. Remove it.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Sep 8, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Sep 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 8, 2025
@overlookmotel overlookmotel marked this pull request as ready for review September 8, 2025 11:31
Copilot AI review requested due to automatic review settings September 8, 2025 11:31
Copilot AI reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dead code from the raw transfer codegen following a previous refactoring. After PR #13432 removed usage of constructor_names, this field and its related code became obsolete.

  • Removes the unused constructor_names field from the State struct
  • Removes initialization of the constructor_names field
  • Removes code that populated the constructor_names field in generate_struct

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel
Copy link
Member Author

overlookmotel commented Sep 8, 2025 •
edited
Loading

Does not alter output of the codegen, so it's evidently fine. Merging without review.

Edit: Ha! Cam is too fast!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 8, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Sep 8, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
refactor(ast_tools): remove dead code from raw transfer codegen (#13594)
fd277b4 
Follow-on after #13432. That PR removed usage of `constructor_names`, so it's now dead code. Remove it.
@graphite-app graphite-app bot force-pushed the 09-08-refactor_ast_tools_remove_dead_code_from_raw_transfer_codegen branch from 482e0a7 to fd277b4 Compare September 8, 2025 11:36
@graphite-app graphite-app bot merged commit fd277b4 into main Sep 8, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-08-refactor_ast_tools_remove_dead_code_from_raw_transfer_codegen branch September 8, 2025 11:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314