Skip to content

feat(minifier): remove unnecessary parenthesis from nested optional chaining#13268

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining
Aug 24, 2025
Merged

feat(minifier): remove unnecessary parenthesis from nested optional chaining#13268
graphite-app[bot] merged 1 commit intomainfrom
08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 23, 2025 •
edited
Loading

Flatten nested chain expressions like (a?.b)?.c to a?.b?.c.

@github-actions github-actions bot added A-minifier Area - Minifier A-ast Area - AST C-enhancement Category - New feature or request labels Aug 23, 2025
@sapphi-red sapphi-red mentioned this pull request Aug 23, 2025
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Aug 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Aug 23, 2025
Merged
@sapphi-red sapphi-red marked this pull request as ready for review August 23, 2025 09:11
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 23, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13268 will degrade performances by 5.48%

Comparing 08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining (53f55a4) with main (e7a49ed)1

Summary

❌ 1 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ minifier[react.development.js] 2.1 ms 2.3 ms -5.48%

Footnotes

  1. No successful run was found on main (53f55a4) during the generation of this report, so e7a49ed was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Boshen Boshen self-assigned this Aug 23, 2025
@sapphi-red sapphi-red force-pushed the 08-20-feat_minifier_collect_symbol_information_for_vars branch from dadfdc6 to 93236d4 Compare August 24, 2025 05:37
@sapphi-red sapphi-red force-pushed the 08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining branch from f927fe5 to ac40524 Compare August 24, 2025 05:37
This was referenced Aug 24, 2025
Merged
Merged
Merged
@sapphi-red sapphi-red force-pushed the 08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining branch from ac40524 to 35ddeef Compare August 24, 2025 06:38
@sapphi-red sapphi-red force-pushed the 08-20-feat_minifier_collect_symbol_information_for_vars branch from 93236d4 to 19ab2c0 Compare August 24, 2025 06:38
@sapphi-red sapphi-red mentioned this pull request Aug 24, 2025
Merged
@sapphi-red sapphi-red force-pushed the 08-20-feat_minifier_collect_symbol_information_for_vars branch from 19ab2c0 to b9a5d6e Compare August 24, 2025 06:42
@sapphi-red sapphi-red force-pushed the 08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining branch from 35ddeef to 77a4a2f Compare August 24, 2025 06:42
This was referenced Aug 24, 2025
Merged
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 24, 2025 •
edited
Loading

Merge activity

@sapphi-red
feat(minifier): remove unnecessary parenthesis from nested optional c…
53f55a4 
…haining (#13268)

Flatten nested chain expressions like `(a?.b)?.c` to `a?.b?.c`.
@graphite-app graphite-app bot force-pushed the 08-20-feat_minifier_collect_symbol_information_for_vars branch from b9a5d6e to 8ca9909 Compare August 24, 2025 08:44
@graphite-app graphite-app bot force-pushed the 08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining branch from 77a4a2f to 53f55a4 Compare August 24, 2025 08:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
Base automatically changed from 08-20-feat_minifier_collect_symbol_information_for_vars to main August 24, 2025 08:50
@graphite-app graphite-app bot merged commit 53f55a4 into main Aug 24, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-23-feat_minifier_remove_unnecessary_parenthesis_from_nested_optional_chaining branch August 24, 2025 08:51
@oxc-bot oxc-bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Boshen Boshen

Labels

A-ast Area - AST A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Boshen