refactor(linter): pass paths to TsGoLintState.lint method#13131
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 16, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
43b1899 to
e1d58c4
Compare
CodSpeed Instrumentation Performance ReportMerging #13131 will not alter performanceComparing Summary
Footnotes |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TsGoLintState struct to remove the lifetime parameter by moving paths from the constructor to the lint method. This change supports a language server architecture where files are linted on-demand when requested by the client, rather than storing all paths upfront.
- Removes lifetime parameter
'afromTsGoLintStatestruct - Moves
pathsparameter from constructor tolintmethod - Updates call site in
apps/oxlint/src/lint.rsto match new API
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_linter/src/tsgolint.rs | Removes lifetime parameter and paths field from TsGoLintState, adds paths parameter to lint method |
| apps/oxlint/src/lint.rs | Updates TsGoLintState usage to match new constructor and lint method signatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
camc314
approved these changes
Aug 15, 2025
Contributor
Merge activity
|
e1d58c4 to
31d3d0f
Compare
e065911 to
f0a517f
Compare
31d3d0f to
53057b9
Compare
The language server does need to hold all paths. It will lint when the client is requesting a file
53057b9 to
8459a12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language server does need to hold all paths. It will lint when the client is requesting a file