Skip to content

fix(napi/oxlint): return diagnostics even if AST is not visited#12479

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-23-fix_napi_oxlint_return_diagnostics_even_if_ast_is_not_visited
Jul 23, 2025
Merged

fix(napi/oxlint): return diagnostics even if AST is not visited#12479
graphite-app[bot] merged 1 commit intomainfrom
07-23-fix_napi_oxlint_return_diagnostics_even_if_ast_is_not_visited

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Jul 23, 2025 •
edited
Loading

Fix a bug introduced in #12472. It's possible for a rule to generate diagnostics in create even if it doesn't visit the AST.

Following PR adds tests for this.

@github-actions github-actions Bot added the C-bug Category - Bug label Jul 23, 2025
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Jul 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 23, 2025
Merged
Closed
@overlookmotel overlookmotel marked this pull request as ready for review July 23, 2025 16:05
@overlookmotel overlookmotel requested a review from camc314 July 23, 2025 16:05
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@camc314 Graphite App
Copy link
Copy Markdown
Contributor

camc314 commented Jul 23, 2025 •
edited by graphite-app Bot
Loading

Merge activity

@overlookmotel
fix(napi/oxlint): return diagnostics even if AST is not visited (#12479)
8df01c0 
Fix a bug introduced in #12472. It's possible for a rule to generate diagnostics in `create` even if it doesn't visit the AST.

Following PR adds tests for this.
@graphite-app graphite-app Bot force-pushed the 07-23-fix_napi_oxlint_return_diagnostics_even_if_ast_is_not_visited branch from 4c8707b to 8df01c0 Compare July 23, 2025 16:11
@graphite-app graphite-app Bot merged commit 8df01c0 into main Jul 23, 2025
15 checks passed
@graphite-app graphite-app Bot deleted the 07-23-fix_napi_oxlint_return_diagnostics_even_if_ast_is_not_visited branch July 23, 2025 16:19
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@overlookmotel overlookmotel mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314

Assignees

No one assigned

Labels

C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314