Skip to content

feat(linter): Add id-length rule from eslint#11887

Merged
camc314 merged 7 commits intooxc-project:mainfrom
nrayburn-tech:implement-id-length
Jun 29, 2025
Merged

feat(linter): Add id-length rule from eslint#11887
camc314 merged 7 commits intooxc-project:mainfrom
nrayburn-tech:implement-id-length

Conversation

@nrayburn-tech
Copy link
Collaborator

No description provided.

@nrayburn-tech nrayburn-tech requested a review from camc314 as a code owner June 24, 2025 23:51
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jun 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 24, 2025

CodSpeed Instrumentation Performance Report

Merging #11887 will degrade performances by 13.36%

Comparing nrayburn-tech:implement-id-length (b52bd4b) with main (626d028)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.36%

@nrayburn-tech

This comment was marked as resolved.

@Sysix
Copy link
Member

Sysix commented Jun 25, 2025

I don't understand what the problem is or how to resolve it though.

@nrayburn-tech you need to Box<> your configuration because of the Vec and RegEx.
You can find an example here: https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs

@github-actions github-actions bot added the A-cli Area - CLI label Jun 26, 2025
@camc314 camc314 merged commit 8e1573d into oxc-project:main Jun 29, 2025
24 checks passed
@nrayburn-tech nrayburn-tech deleted the implement-id-length branch July 10, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants