Skip to content

feat(ast): Add AstKind to TSTupleType node#11749

Merged
camc314 merged 2 commits intooxc-project:mainfrom
therewillbecode:add-astkind-tuple
Jun 16, 2025
Merged

feat(ast): Add AstKind to TSTupleType node#11749
camc314 merged 2 commits intooxc-project:mainfrom
therewillbecode:add-astkind-tuple

Conversation

@therewillbecode
Copy link
Copy Markdown
Contributor

This PR is part of the ongoing work in #11490 .

Adds AstKind to TSTupleType nodes by removing the entry from the list of exceptions in ast_tools.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jun 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request labels Jun 16, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 16, 2025

CodSpeed Instrumentation Performance Report

Merging #11749 will degrade performances by 4.08%

Comparing therewillbecode:add-astkind-tuple (baa15be) with main (3d89012)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.2 ms -4.08%

@camc314 camc314 merged commit b949ece into oxc-project:main Jun 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants