Skip to content

fix(linter): correct labels for redundant comparisons#11620

Merged
Boshen merged 1 commit intooxc-project:mainfrom
yesmeck:fix-wrong-message-for-const-comparisons
Jun 12, 2025
Merged

fix(linter): correct labels for redundant comparisons#11620
Boshen merged 1 commit intooxc-project:mainfrom
yesmeck:fix-wrong-message-for-const-comparisons

Conversation

@yesmeck
Copy link
Copy Markdown
Contributor

@yesmeck yesmeck commented Jun 12, 2025

The labels were displayed in an opposite order.

@yesmeck yesmeck requested a review from camc314 as a code owner June 12, 2025 01:56
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jun 12, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jun 12, 2025
@yesmeck yesmeck changed the title fix(linter): correct labels redundant comparisons fix(linter): correct labels for redundant comparisons Jun 12, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 12, 2025

CodSpeed Instrumentation Performance Report

Merging #11620 will degrade performances by 12.14%

Comparing yesmeck:fix-wrong-message-for-const-comparisons (a15537f) with main (40b3a0e)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -12.14%

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 12, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jun 12, 2025

Merge activity

  • Jun 12, 3:32 AM UTC: @yesmeck we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 12, 2025
@yesmeck yesmeck force-pushed the fix-wrong-message-for-const-comparisons branch from 19f2957 to a15537f Compare June 12, 2025 03:55
@Boshen Boshen merged commit 0f24366 into oxc-project:main Jun 12, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants