Skip to content

feat(parser): produce syntax error for interface A implements B {}#11608

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-11-feat_parser_produce_syntax_error_for_interface_a_implements_b_
Jun 11, 2025
Merged

feat(parser): produce syntax error for interface A implements B {}#11608
graphite-app[bot] merged 1 commit intomainfrom
06-11-feat_parser_produce_syntax_error_for_interface_a_implements_b_

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Jun 11, 2025

fixes #11591

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Jun 11, 2025
@Boshen Boshen mentioned this pull request Jun 11, 2025
Merged
@Boshen Graphite App
Copy link
Copy Markdown
Member Author

Boshen commented Jun 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen mentioned this pull request Jun 11, 2025
Merged
Base automatically changed from 06-11-feat_parser_produce_syntax_error_for_declare_function_foo_ to main June 11, 2025 12:42
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 11, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11608 will degrade performances by 12.76%

Comparing 06-11-feat_parser_produce_syntax_error_for_interface_a_implements_b_ (ab3284a) with main (844a8a8)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ mangler[cal.com.tsx] 3.1 ms 3.5 ms -12.76%

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jun 11, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 06-11-feat_parser_produce_syntax_error_for_interface_a_implements_b_ branch from 3f141fa to ab3284a Compare June 11, 2025 12:45
@graphite-app graphite-app bot merged commit ab3284a into main Jun 11, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-11-feat_parser_produce_syntax_error_for_interface_a_implements_b_ branch June 11, 2025 12:51
@oxc-bot oxc-bot mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Forbid interface A implements B {}

1 participant

@Boshen