Skip to content

fix(linter): improve span diagnostic loc within react/rules-of-hooks#11589

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/06-10-fix_linter_improve_span_diagnostic_loc_within_react_rules-of-hooks
Jun 10, 2025
Merged

fix(linter): improve span diagnostic loc within react/rules-of-hooks#11589
graphite-app[bot] merged 1 commit intomainfrom
c/06-10-fix_linter_improve_span_diagnostic_loc_within_react_rules-of-hooks

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Jun 10, 2025

closes #11587

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jun 10, 2025
Copy link
Copy Markdown
Contributor Author

camc314 commented Jun 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review June 10, 2025 14:02
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jun 10, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/06-10-fix_linter_improve_span_diagnostic_loc_within_react_rules-of-hooks branch from eabad11 to 779727f Compare June 10, 2025 14:05
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 10, 2025

CodSpeed Instrumentation Performance Report

Merging #11589 will degrade performances by 3.03%

Comparing c/06-10-fix_linter_improve_span_diagnostic_loc_within_react_rules-of-hooks (779727f) with main (d29bbb2)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[cal.com.tsx] 23.1 ms 23.9 ms -3.03%

@graphite-app graphite-app bot merged commit 779727f into main Jun 10, 2025
23 checks passed
@graphite-app graphite-app bot deleted the c/06-10-fix_linter_improve_span_diagnostic_loc_within_react_rules-of-hooks branch June 10, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: React Hook "RootLayout" cannot be called in an async function.

1 participant