Skip to content

chore(linter): mark react/exhaustive-deps as correctness#11399

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/05-30-chore_linter_mark_react_exhaustive-deps_as_correctness
May 30, 2025
Merged

chore(linter): mark react/exhaustive-deps as correctness#11399
graphite-app[bot] merged 1 commit intomainfrom
c/05-30-chore_linter_mark_react_exhaustive-deps_as_correctness

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented May 30, 2025 •
edited
Loading

this rule has been around for several months, and all bugs regarding it have been fixed.

lets mark it as correctness and address any issues as they appear

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 30, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented May 30, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review May 30, 2025 15:12
@graphite-app
Copy link
Contributor

graphite-app bot commented May 30, 2025 •
edited
Loading

Merge activity

@camc314 camc314 mentioned this pull request May 30, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 30, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11399 will create unknown performance changes

Comparing c/05-30-chore_linter_mark_react_exhaustive-deps_as_correctness (3f462f1) with main (2083d33)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132.1 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.9 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 299.7 µs N/A
🆕 formatter[binder.ts] N/A 19.3 ms N/A
🆕 formatter[cal.com.tsx] N/A 150.4 ms N/A
🆕 formatter[react.development.js] N/A 9.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.1 µs N/A
🆕 lexer[binder.ts] N/A 929.2 µs N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[react.development.js] N/A 383.7 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 149.2 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.6 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.2 µs N/A
🆕 mangler[binder.ts] N/A 798.4 µs N/A
🆕 mangler[cal.com.tsx] N/A 3 ms N/A
🆕 mangler[react.development.js] N/A 283.2 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camc314 camc314 mentioned this pull request May 30, 2025
Merged
@camc314
chore(linter): mark react/exhaustive-deps as correctness (#11399)
3f462f1 
this rule has been around for several months, and all bugs regarding it have been fixed.

lets mark it as correctness and address any issues as they appear
@graphite-app graphite-app bot force-pushed the c/05-30-chore_linter_mark_react_exhaustive-deps_as_correctness branch from 05ce554 to 3f462f1 Compare May 30, 2025 15:19
@graphite-app graphite-app bot merged commit 3f462f1 into main May 30, 2025
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 30, 2025
@graphite-app graphite-app bot deleted the c/05-30-chore_linter_mark_react_exhaustive-deps_as_correctness branch May 30, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314