Skip to content

fix(language_server): on configuration change, send updated diagnostics to the client#10764

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-02-fix_language_server_on_configuration_change_send_updated_diagnostics_to_the_client
May 3, 2025
Merged

fix(language_server): on configuration change, send updated diagnostics to the client#10764
graphite-app[bot] merged 1 commit intomainfrom
05-02-fix_language_server_on_configuration_change_send_updated_diagnostics_to_the_client

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 2, 2025

No description provided.

@Sysix Graphite App
Copy link
Member Author

Sysix commented May 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels May 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 2, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10764 will not alter performance

Comparing 05-02-fix_language_server_on_configuration_change_send_updated_diagnostics_to_the_client (eb3f37c) with main (8c499c6)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix force-pushed the 05-02-fix_language_server_on_configuration_change_send_updated_diagnostics_to_the_client branch from b464123 to 16db482 Compare May 2, 2025 14:23
@Sysix Sysix marked this pull request as ready for review May 2, 2025 14:26
@Sysix Sysix requested review from camc314 and camchenry May 2, 2025 14:27
@coderabbitai
Copy link

coderabbitai bot commented May 2, 2025 •
edited
Loading

Walkthrough

The changes update the language server backend’s did_change_configuration async method to collect and aggregate diagnostics returned by each worker after configuration changes. Previously, diagnostics returned by workers were ignored; now they are gathered into a concurrent hashmap and published to the client if any diagnostics are present. This applies to both single and multiple workspace scenarios, with handling for client support of workspace configuration requests. In the Visual Studio Code extension, a new test case is added to verify that changing the 'fix_kind' flag in the 'oxc.flags' configuration dynamically alters the number of quick fix code actions available for a TypeScript file. The test uses a newly added fixture containing a for loop with a decrementing counter that conflicts with its continuation condition. A teardown hook is also introduced to reset the 'oxc.flags' configuration and save all workspace files after each test. No changes were made to public entity signatures; all modifications are internal or pertain to tests and fixtures.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16db482 and eb3f37c.

📒 Files selected for processing (3)
  • crates/oxc_language_server/src/main.rs (2 hunks)
  • editors/vscode/client/extension.spec.ts (2 hunks)
  • editors/vscode/fixtures/changing_fix_kind/for_direction.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • editors/vscode/client/extension.spec.ts
  • crates/oxc_language_server/src/main.rs
🧰 Additional context used
🪛 Biome (1.9.4)
editors/vscode/fixtures/changing_fix_kind/for_direction.ts

[error] 1-1: The update clause in this loop moves the variable in the wrong direction.

(lint/correctness/useValidForDirection)

⏰ Context from checks skipped due to timeout of 90000ms (14)
  • GitHub Check: Benchmark (formatter)
  • GitHub Check: Test wasm32-wasip1-threads
  • GitHub Check: Benchmark (codegen)
  • GitHub Check: Test (macos-latest)
  • GitHub Check: Benchmark (minifier)
  • GitHub Check: Test (ubuntu-latest)
  • GitHub Check: Benchmark (semantic)
  • GitHub Check: Benchmark (isolated_declarations)
  • GitHub Check: Benchmark (transformer)
  • GitHub Check: Clippy
  • GitHub Check: Benchmark (parser)
  • GitHub Check: Benchmark (lexer)
  • GitHub Check: Test
  • GitHub Check: Build Linter Benchmark
🔇 Additional comments (1)
editors/vscode/fixtures/changing_fix_kind/for_direction.ts (1)

1-1: Intentional test fixture with a for loop direction issue.

This code correctly implements a test fixture with an intentional loop direction issue (decrementing i-- while checking i < 10). This creates an infinite loop scenario that's perfect for testing how the language server's diagnostics and code actions respond to configuration changes, specifically the 'fix_kind' flag.

The static analysis correctly identifies this as an error, which is exactly what we want for testing the diagnostic capabilities.

🧰 Tools
🪛 Biome (1.9.4)

[error] 1-1: The update clause in this loop moves the variable in the wrong direction.

(lint/correctness/useValidForDirection)

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label May 3, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented May 3, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 05-02-fix_language_server_on_configuration_change_send_updated_diagnostics_to_the_client branch from 16db482 to eb3f37c Compare May 3, 2025 09:11
@graphite-app graphite-app bot merged commit eb3f37c into main May 3, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-02-fix_language_server_on_configuration_change_send_updated_diagnostics_to_the_client branch May 3, 2025 09:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camchenry camchenry camchenry approved these changes

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sysix @camchenry