Skip to content

feat(transformer, napi/transform): deprecate allowDeclareFields option#10584

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option
Apr 25, 2025
Merged

feat(transformer, napi/transform): deprecate allowDeclareFields option#10584
graphite-app[bot] merged 1 commit intomainfrom
04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 24, 2025

After the removeClassFieldsWithoutInitializer option is supported, allowDeclareFields is no longer needed. More detail see #10491 (comment)

Copy link
Member Author

Dunqing commented Apr 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Instrumentation Performance Report

Merging #10584 will not alter performance

Comparing 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option (42ca96a) with 04-24-docs_transformer_add_documentation_for_compilerassumptions_set_public_class_fields (73cd730)

Summary

✅ 35 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[checker.ts] N/A 3 s N/A

@Dunqing Dunqing marked this pull request as ready for review April 24, 2025 08:28
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 24, 2025 08:28
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from fbf48d4 to b087a5a Compare April 24, 2025 08:30
@Dunqing Dunqing force-pushed the 04-24-docs_transformer_add_documentation_for_compilerassumptions_set_public_class_fields branch 2 times, most recently from 279b8d4 to cd422cb Compare April 24, 2025 09:56
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from b087a5a to c7f3c06 Compare April 24, 2025 09:56
@Dunqing Dunqing requested a review from sapphi-red April 24, 2025 09:57
@Dunqing Dunqing force-pushed the 04-24-docs_transformer_add_documentation_for_compilerassumptions_set_public_class_fields branch from cd422cb to f86cc52 Compare April 24, 2025 14:09
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from c7f3c06 to 85c0a39 Compare April 24, 2025 14:09
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 25, 2025

Merge activity

…ion (#10584)

After the `removeClassFieldsWithoutInitializer` option is supported, `allowDeclareFields` is no longer needed. More detail see #10491 (comment)
@graphite-app graphite-app bot force-pushed the 04-24-docs_transformer_add_documentation_for_compilerassumptions_set_public_class_fields branch from f86cc52 to 73cd730 Compare April 25, 2025 01:31
@graphite-app graphite-app bot force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from 85c0a39 to 42ca96a Compare April 25, 2025 01:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
Base automatically changed from 04-24-docs_transformer_add_documentation_for_compilerassumptions_set_public_class_fields to main April 25, 2025 01:45
@graphite-app graphite-app bot merged commit 42ca96a into main Apr 25, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch April 25, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants