feat(codegen): Revert "feat(codegen)!: print StringLiteral raw if minify option disabled (#10553)#10569
Merged
feat(codegen): Revert "feat(codegen)!: print StringLiteral raw if minify option disabled (#10553)#10569
StringLiteral raw if minify option disabled (#10553)#10569Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Instrumentation Performance ReportMerging #10569 will not alter performanceComparing Summary
|
StringLiteral raw if minify option disabled (#10553)StringLiteral raw if minify option disabled (#10553)
StringLiteral raw if minify option disabled (#10553)StringLiteral raw if minify option disabled (#10553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 10e1018.
After experimenting with downstream crates like Rolldown, I discovered this introduces a footgun.
It's really easy to change
StringLiteral::valuewithout also changingStringLiteral::raw, which results in incorrect codegen.After some consideration, I've decided against introducing an extra option for printing the raw value, it adds a significant amount of maintenance burden. (This issue alone is already consuming a lot of our time). We will need to three modes in the codegen: normal, minify and raw.
For now, let's assume our codegen will not preserve the original source text. If preserving the original source text is a requirement, please use magic string or any other direct string manipulation methods.