Skip to content

refactor(transformer/typescript): do not need to go through TSModuleDeclaration if is a NamespaceModule#10366

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule
Apr 14, 2025
Merged

refactor(transformer/typescript): do not need to go through TSModuleDeclaration if is a NamespaceModule#10366
graphite-app[bot] merged 1 commit intomainfrom
04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented Apr 11, 2025 •
edited
Loading

Benefits from #10350. NamespaceModule means this TSModuleDeclaration is a type-only declaration, so that we can get rid of it early without going through its block.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 11, 2025
@Dunqing Graphite App
Copy link
Copy Markdown
Member Author

Dunqing commented Apr 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Apr 11, 2025
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 11, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10366 will not alter performance

Comparing 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule (032377d) with main (1ff75bc)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing changed the base branch from 04-11-test_transformer_typescript_override_namespace_empty-removed_test to graphite-base/10366 April 11, 2025 09:48
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from 23fc8e8 to b89e69c Compare April 11, 2025 09:49
@Dunqing Dunqing force-pushed the graphite-base/10366 branch from 6bd8331 to 992b6e0 Compare April 11, 2025 09:49
@Dunqing Dunqing changed the base branch from graphite-base/10366 to 04-11-test_transformer_typescript_override_namespace_empty-removed_test April 11, 2025 09:49
This was referenced Apr 11, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@graphite-app graphite-app bot force-pushed the 04-11-test_transformer_typescript_override_namespace_empty-removed_test branch 2 times, most recently from 5a22fb5 to 7ff5df5 Compare April 11, 2025 10:29
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from b89e69c to 16606b1 Compare April 11, 2025 10:29
@Dunqing Dunqing marked this pull request as ready for review April 11, 2025 11:38
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 11, 2025 11:38
@Dunqing Dunqing force-pushed the 04-11-test_transformer_typescript_override_namespace_empty-removed_test branch from 7ff5df5 to a121149 Compare April 12, 2025 11:37
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from 16606b1 to 13126c1 Compare April 12, 2025 11:37
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 12, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 12, 2025 •
edited
Loading

Merge activity

graphite-app bot pushed a commit that referenced this pull request Apr 12, 2025
@Dunqing
test(transformer/typescript): override namespace/empty-removed test (#…
c25eab0 
…10365)

Just override the test without any changes to prepare for #10366.
@graphite-app graphite-app bot force-pushed the 04-11-test_transformer_typescript_override_namespace_empty-removed_test branch from a121149 to c25eab0 Compare April 12, 2025 13:39
graphite-app bot pushed a commit that referenced this pull request Apr 12, 2025
@Dunqing
refactor(transformer/typescript): do not need to go through `TSModule…
cbb8d33 
…Declaration` if is a `NamespaceModule` (#10366)

Benefits from #10350. `NamespaceModule` means this `TSModuleDeclaration` is a type-only declaration, so that we can get rid of it early without going through its block.
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from 13126c1 to cbb8d33 Compare April 12, 2025 13:40
Base automatically changed from 04-11-test_transformer_typescript_override_namespace_empty-removed_test to main April 12, 2025 13:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 12, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 13, 2025
@Dunqing Dunqing added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Apr 14, 2025
Dunqing added a commit that referenced this pull request Apr 14, 2025
@Dunqing
refactor(transformer/typescript): do not need to go through `TSModule…
9de9c6c 
…Declaration` if is a `NamespaceModule` (#10366)

Benefits from #10350. `NamespaceModule` means this `TSModuleDeclaration` is a type-only declaration, so that we can get rid of it early without going through its block.
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from cbb8d33 to 9de9c6c Compare April 14, 2025 02:39
@Dunqing
refactor(transformer/typescript): do not need to go through `TSModule…
032377d 
…Declaration` if is a `NamespaceModule` (#10366)

Benefits from #10350. `NamespaceModule` means this `TSModuleDeclaration` is a type-only declaration, so that we can get rid of it early without going through its block.
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from 9de9c6c to 032377d Compare April 14, 2025 02:49
@graphite-app graphite-app bot merged commit 032377d into main Apr 14, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch April 14, 2025 02:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
@oxc-bot oxc-bot mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dunqing