Skip to content

fix(coverage): test262 must be executed twice with and without strict mode#10125

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-30-fix_coverage_test262_must_be_executed_twice_with_and_without_strict_mode
Mar 31, 2025
Merged

fix(coverage): test262 must be executed twice with and without strict mode#10125
graphite-app[bot] merged 1 commit intomainfrom
03-30-fix_coverage_test262_must_be_executed_twice_with_and_without_strict_mode

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Mar 30, 2025

fixes #10057

@Boshen Boshen requested a review from Dunqing March 30, 2025 06:18
@github-actions github-actions bot added the C-bug Category - Bug label Mar 30, 2025
Copy link
Copy Markdown
Member Author

Boshen commented Mar 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen force-pushed the 03-30-fix_coverage_test262_must_be_executed_twice_with_and_without_strict_mode branch 4 times, most recently from 1157fbe to 3ce5805 Compare March 30, 2025 12:00
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
Copy link
Copy Markdown
Member

Dunqing commented Mar 31, 2025

Merge activity

  • Mar 31, 1:46 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 31, 1:46 AM EDT: Dunqing added this pull request to the Graphite merge queue.
  • Mar 31, 1:53 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 03-30-fix_coverage_test262_must_be_executed_twice_with_and_without_strict_mode branch from 3ce5805 to 4125e86 Compare March 31, 2025 05:47
@graphite-app graphite-app bot merged commit 4125e86 into main Mar 31, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 03-30-fix_coverage_test262_must_be_executed_twice_with_and_without_strict_mode branch March 31, 2025 05:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coverage: do not run test in strict mode when it doesn't contain onlyStrict and module flags

2 participants