Skip to content

refactor(editor): make onConfigChange async#10110

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-28-refactor_editor_make_onconfigchange_async
Mar 29, 2025
Merged

refactor(editor): make onConfigChange async#10110
graphite-app[bot] merged 1 commit intomainfrom
03-28-refactor_editor_make_onconfigchange_async

Conversation

@Sysix
Copy link
Copy Markdown
Member

@Sysix Sysix commented Mar 28, 2025

No description provided.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 28, 2025
Copy link
Copy Markdown
Member Author

Sysix commented Mar 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review March 28, 2025 15:27
@graphite-app graphite-app bot changed the base branch from 03-28-fix_editor_repair_filewatchers_when_no_custom_config_provided to graphite-base/10110 March 29, 2025 00:05
@graphite-app graphite-app bot force-pushed the 03-28-refactor_editor_make_onconfigchange_async branch from 24a2085 to e8e8649 Compare March 29, 2025 00:11
@graphite-app graphite-app bot force-pushed the graphite-base/10110 branch from 16571cd to ac780a2 Compare March 29, 2025 00:11
@graphite-app graphite-app bot changed the base branch from graphite-base/10110 to main March 29, 2025 00:12
@graphite-app graphite-app bot force-pushed the 03-28-refactor_editor_make_onconfigchange_async branch from e8e8649 to b855653 Compare March 29, 2025 00:12
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Mar 29, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 03-28-refactor_editor_make_onconfigchange_async branch from b855653 to 5ec477c Compare March 29, 2025 14:03
@graphite-app graphite-app bot merged commit 5ec477c into main Mar 29, 2025
19 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
@graphite-app graphite-app bot deleted the 03-28-refactor_editor_make_onconfigchange_async branch March 29, 2025 14:11
Boshen added a commit that referenced this pull request Apr 1, 2025
## [0.16.4] - 2025-04-01

- da6336c language_server: [**BREAKING**] Remove `enable` configuration,
the client should shutdown the server instead (#9990) (Sysix)

### Features

- 06e3db9 linter: Support `multipleFileExtensions` option for
`unicorn/filename-case` (#10118) (shulaoda)
- dbe0e46 linter: Support `ignore` option for `unicorn/filename-case`
(#10107) (shulaoda)

### Bug Fixes

- 0a33e27 editor: Update `initializationOptions` for a possible restart
(#10121) (Sysix)
- ac780a2 editor: Repair filewatchers when no custom config provided
(#10104) (Sysix)
- 4303ace editor: Dont send `didChangeConfiguration` request to the
server when it is shutdown (#10084) (Sysix)
- 07f2a25 editor: Enable regex parsing in language server (#10035)
(camchenry)
- fcf7702 language_server: Start from a default oxlint configuration +
SafeFix for nested configuration (#10043) (Sysix)
- aba3654 linter: Span disable directive correctly on next line (#10141)
(Ulrich Stark 🦀)
- 2c80858 linter: Enable multi-file analysis for nested configs (#10089)
(camchenry)

### Performance

- 566be59 linter: Replace `phf_set` with `array` in `eslint/func-names`
(#10119) (shulaoda)
- 5e14fe9 linter: Inline `PRE_DEFINE_VAR` and use `array` format
(#10079) (shulaoda)

### Refactor

- 327be53 editor: `LanguageClient` can be undefined (#10112) (Sysix)
- 5ec477c editor: Make `onConfigChange` async (#10110) (Sysix)
- a278d73 editor: Use warning background when the plugin is deactived
(#10085) (Sysix)
- c0e5251 language_server: Set `null` as a default value for
`configPath` (#10047) (Sysix)
- 09c0ac6 linter: Improve `unicorn/filename-case` (#10117) (shulaoda)
- d8e49a1 linter: Compute lintable extensions at compile time (#10090)
(camchenry)
- b3ec235 linter: Use items of `oxc_ast::ast` module directly (#10100)
(Ulrich Stark 🦀)
- 93e6c0b linter: Use `FormalParameter::has_modifier` to detect
parameter properties (#10097) (Ulrich Stark 🦀)
- 5d829c2 semantic: Align handling of declaring symbol for function with
TypeScript (#10086) (Dunqing)

### Testing

- 410b8d6 editor: Use debug build of the language server (#10083)
(Sysix)
- 500add0 editor: Add test for `oxc.fixAll` command (#10045) (Sysix)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants