Skip to content

fix(isolated_declarations,linter,semantic,transformer): use FormalParameter::has_modifier to detect parameter property#10081

Closed
ulrichstark wants to merge 2 commits intooxc-project:mainfrom
ulrichstark:use-formalparameter-hasmodifier-for-detecting-parameter-property
Closed

fix(isolated_declarations,linter,semantic,transformer): use FormalParameter::has_modifier to detect parameter property#10081
ulrichstark wants to merge 2 commits intooxc-project:mainfrom
ulrichstark:use-formalparameter-hasmodifier-for-detecting-parameter-property

Conversation

@ulrichstark
Copy link
Copy Markdown
Contributor

@ulrichstark ulrichstark commented Mar 27, 2025 •
edited
Loading

Using FormalParameter::has_modifier makes code shorter, more explicit and also fixes code which hasn't checked for the override and readonly modifier before.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Mar 27, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler A-isolated-declarations Isolated Declarations labels Mar 27, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10081 will not alter performance

Comparing ulrichstark:use-formalparameter-hasmodifier-for-detecting-parameter-property (abf5abe) with main (5e14fe9)

Summary

✅ 33 untouched benchmarks

@ulrichstark ulrichstark changed the title refactor: use FormalParameter::has_modifier to detect parameter property refactor(isolated_declarations,linter,semantic,transformer): use FormalParameter::has_modifier to detect parameter property Mar 27, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 27, 2025
@ulrichstark ulrichstark changed the title refactor(isolated_declarations,linter,semantic,transformer): use FormalParameter::has_modifier to detect parameter property fix(isolated_declarations,linter,semantic,transformer): use FormalParameter::has_modifier to detect parameter property Mar 27, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Mar 27, 2025
@Dunqing
Copy link
Copy Markdown
Member

Dunqing commented Mar 28, 2025

Thank you! Could you split this PR into twos?

The first one is to shorten the code by using FormalParameter::has_modifier, and the second one is to fix the isolated declaration issue. So that what you want to do will be clearer, and easier for maintainers to review.

This was referenced Mar 28, 2025
Merged
Merged
Merged
Merged
Dunqing pushed a commit that referenced this pull request Mar 28, 2025
@ulrichstark
refactor(linter): use FormalParameter::has_modifier to detect param…
93e6c0b 
…eter properties (#10097)

By using this function, the code is shorter and the missing check for
the `override` modifier is added.

This PR is the result of splitting #10081 into smaller PRs.
Dunqing pushed a commit that referenced this pull request Mar 28, 2025
@ulrichstark
refactor(isolated_declarations): use FormalParameter::has_modifier …
4020567 
…to detect parameter properties (#10098)

By using this function, the code is shorter and the missing check for
the `override` modifier is added.

This PR is the result of splitting
#10081 into smaller PRs.
Dunqing pushed a commit that referenced this pull request Mar 28, 2025
@ulrichstark
refactor(transformer): use FormalParameter::has_modifier to detect …
2720204 
…parameter properties (#10099)

By using this function, the code is shorter and aligns with the changes
of the original PR.

This PR is the result of splitting #10081 into smaller PRs.
@ulrichstark ulrichstark deleted the use-formalparameter-hasmodifier-for-detecting-parameter-property branch March 28, 2025 10:41
Boshen pushed a commit that referenced this pull request Mar 30, 2025
@ulrichstark
fix(semantic): use FormalParameter::has_modifier to detect paramete…
bcd9a03 
…r properties (#10096)

Checks for the `override` and `readonly` modifier were missing before.

This PR is the result of splitting #10081 into smaller PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@Boshen Boshen Awaiting requested review from Boshen

Assignees

No one assigned

Labels

A-isolated-declarations Isolated Declarations A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ulrichstark @Dunqing