[OCISDEV-704] Dont write ExternalID when empty#12085
Merged
kobergj merged 1 commit intostable-8.0from Mar 9, 2026
Merged
Conversation
mklos-kw
approved these changes
Mar 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes LDAP user creation in the graph service by avoiding writing an empty externalID attribute to LDAP entries (a behavior that can break user creation on some LDAP servers, impacting ocis 8.0.0).
Changes:
- Stop including the
externalIDLDAP attribute whenuser.GetExternalID()is empty. - Extend
TestCreateUserto cover both “with externalID” and “without externalID” scenarios. - Add an unreleased changelog entry documenting the bugfix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/graph/pkg/identity/ldap.go | Only adds externalID to LDAP attributes map when non-empty. |
| services/graph/pkg/identity/ldap_test.go | Updates create-user test to validate behavior with/without externalID. |
| changelog/unreleased/fix-dont-write-empty-externalid-to-ldap.md | Documents the bugfix for release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
d8cb80e to
fdc67b0
Compare
mzner
approved these changes
Mar 4, 2026
Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
fdc67b0 to
dc754e6
Compare
|
ownclouders
pushed a commit
that referenced
this pull request
Mar 9, 2026
[OCISDEV-704] Dont write ExternalID when empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with ocis not being able to create new users in 8.0.0