Skip to content

fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe#11533

Merged
2403905 merged 1 commit intoowncloud:stable-7.1from
2403905:OCISDEV-198
Jul 17, 2025
Merged

fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe#11533
2403905 merged 1 commit intoowncloud:stable-7.1from
2403905:OCISDEV-198

Conversation

@2403905
Copy link
Contributor

@2403905 2403905 commented Jul 15, 2025

Description

fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarqubecloud
Copy link

@2403905 2403905 requested review from kobergj and saw-jan July 16, 2025 08:09
"properties": {
"name": {
"const": "."
"const": "NewSpace"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this fixes the issue #8355

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saw-jan Should we keep the "." for the parentReference.name when the parent is the space root?

            "parentReference": {
                "driveId": "9f8c2d70-780a-4383-a3b2-fb4310c18076$26664ea7-1276-4da1-8b0b-685e72f5abc7",
                "driveType": "project",
                "id": "9f8c2d70-780a-4383-a3b2-fb4310c18076$26664ea7-1276-4da1-8b0b-685e72f5abc7",
                "name": ".",
                "path": "."
            },

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know the impact. maybe @LukasHirt can help us decide if this is something that web requires/uses

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about older versions but in current master/stable-12, there is no code using the name. In general, we're using the path to display the name in shared with lists and we're falling back to loaded spaces if it does not work for whatever reason.

However, having name: "." feels broken when seeing it in the response. Even though it's root, the space still has name, right? Then why not return it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasHirt Please don't get confused. That is a parent's name. The space name already fixed.
The space roots do not have a path or name as they are referencing themselves.
Keep the "." for the parentReference.name

@2403905 2403905 requested review from LukasHirt and saw-jan July 16, 2025 20:00
@2403905 2403905 requested a review from mklos-kw July 17, 2025 07:26
@mzner mzner self-requested a review July 17, 2025 13:22
@2403905 2403905 enabled auto-merge July 17, 2025 13:22
@2403905 2403905 merged commit 327f73b into owncloud:stable-7.1 Jul 17, 2025
4 checks passed
ownclouders pushed a commit that referenced this pull request Jul 17, 2025
 fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants