fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe#11533
fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe#115332403905 merged 1 commit intoowncloud:stable-7.1from
Conversation
|
| "properties": { | ||
| "name": { | ||
| "const": "." | ||
| "const": "NewSpace" |
There was a problem hiding this comment.
@saw-jan Should we keep the "." for the parentReference.name when the parent is the space root?
"parentReference": {
"driveId": "9f8c2d70-780a-4383-a3b2-fb4310c18076$26664ea7-1276-4da1-8b0b-685e72f5abc7",
"driveType": "project",
"id": "9f8c2d70-780a-4383-a3b2-fb4310c18076$26664ea7-1276-4da1-8b0b-685e72f5abc7",
"name": ".",
"path": "."
},
There was a problem hiding this comment.
I really don't know the impact. maybe @LukasHirt can help us decide if this is something that web requires/uses
There was a problem hiding this comment.
Not sure about older versions but in current master/stable-12, there is no code using the name. In general, we're using the path to display the name in shared with lists and we're falling back to loaded spaces if it does not work for whatever reason.
However, having name: "." feels broken when seeing it in the response. Even though it's root, the space still has name, right? Then why not return it?
There was a problem hiding this comment.
@LukasHirt Please don't get confused. That is a parent's name. The space name already fixed.
The space roots do not have a path or name as they are referencing themselves.
Keep the "." for the parentReference.name
fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe



Description
fix: [OCISDEV-198] Fix space root handling in a graph sharedByMe
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: