Skip to content

Fixing #3095#3096

Merged
raghunayyar merged 2 commits intomasterfrom
add_missing_space_for_new_groups
Apr 24, 2013
Merged

Fixing #3095#3096
raghunayyar merged 2 commits intomasterfrom
add_missing_space_for_new_groups

Conversation

@Niduroki
Copy link
Copy Markdown
Member

Add missing space before newly created groups to fix #3095.

cc @jancborchardt @Raydiation @raghunayyar @tanghus @kabum

@tanghus
Copy link
Copy Markdown
Contributor

tanghus commented Apr 23, 2013

Works OK on FF +1

@MorrisJobke
Copy link
Copy Markdown
Contributor

Isn't it better to handle this with CSS?

@Niduroki
Copy link
Copy Markdown
Member Author

@kabum had to find out where the space around the multiselect options was coming from in the first place …
Stupid newlines :c

Better with css indeed.

@MorrisJobke
Copy link
Copy Markdown
Contributor

could you have a look at the checkboxes at add some left space
Chromium 26
Bildschirmfoto von 2013-04-24 11:28:00
Firefox 20
Bildschirmfoto von 2013-04-24 11:28:45

@MorrisJobke
Copy link
Copy Markdown
Contributor

👍

1 similar comment
@raghunayyar
Copy link
Copy Markdown
Contributor

👍

@raghunayyar raghunayyar merged commit 063e123 into master Apr 24, 2013
@raghunayyar raghunayyar deleted the add_missing_space_for_new_groups branch April 24, 2013 16:33
@lock lock bot locked as resolved and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ownCloud 5.0.5: Groups missing a space when added

4 participants