Skip to content

[stable10] Bump latest symfony and sabre/vobject point versions#30102

Closed
phil-davis wants to merge 2 commits intostable10from
stable10-composer-1
Closed

[stable10] Bump latest symfony and sabre/vobject point versions#30102
phil-davis wants to merge 2 commits intostable10from
stable10-composer-1

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

Backport #29977

@phil-davis phil-davis added this to the development milestone Jan 11, 2018
@phil-davis phil-davis self-assigned this Jan 11, 2018
@phil-davis
Copy link
Copy Markdown
Contributor Author

Note: this also bumps minor versions of other stuff in composer.lock up to similar versions that are in master. That is because the only reasonable way to resolve the backport conflicts for composer.lock is to run composer update again in stable10 to make a nice new composer.lock - and of course that bumps everything it can find to the latest compatible versions.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2018

Codecov Report

Merging #30102 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #30102      +/-   ##
==============================================
- Coverage       58.95%   58.94%   -0.01%     
+ Complexity      18092    18091       -1     
==============================================
  Files            1065     1065              
  Lines           62234    62230       -4     
==============================================
- Hits            36687    36681       -6     
- Misses          25547    25549       +2
Impacted Files Coverage Δ Complexity Δ
drone/src/apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
drone/src/lib/private/App/AppManager.php 85.78% <0%> (-0.29%) 77% <0%> (-1%)
drone/src/lib/private/Server.php 82.55% <0%> (-0.15%) 129% <0%> (ø)
drone/src/lib/private/Installer.php 55.27% <0%> (ø) 93% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e58b4...01ed778. Read the comment docs.

{
"name": "behat/behat",
"version": "v3.3.0",
"version": "v3.4.3",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to only update libs which are related to this change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve conflicts in trying to backport composer.lock it is really necessary to run composer update and let it regenerate composer.lock again. That file is not the sort of thing to hand-edit.
So this here is the result.
What to do?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to update the lock file try running

composer update --lock

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I make a new branch off stable10 and then do composer update --lock no change happens to composer.lock - if I composer update then composer.lock contains changes that bump minor versions of all sorts of stuff to be like what is already in master, because those versions are "waiting to happen" for stable10

For this PR, there is actually no change to composer.json - in master we just did composer update and it bumped what it needed in composer.json When we backport to stable10 we get more stuff bumped because stable10 has not has a composer update for a while.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try make update-composer instead, it should regenerate the lock file. Not sure if that's the same...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used make update-composer this time while doing a rebase to resolve conflicts. That produces a similar result - plenty of bumps of versions like this.

@phil-davis
Copy link
Copy Markdown
Contributor Author

See #30266 for another try at this.

@patrickjahns
Copy link
Copy Markdown
Contributor

@phil-davis
To update just one library - it is straight forward composer update <library> - in this case composer update sabre/vobject

@phil-davis
Copy link
Copy Markdown
Contributor Author

@patrickjahns #30266 has a better attempt at this.
The other version bumps that happen here if you do composer update are things that have already happened in master and need/should/could be bumped in stable10 also.

@phil-davis
Copy link
Copy Markdown
Contributor Author

Done in #30266

@phil-davis phil-davis closed this Feb 6, 2018
@phil-davis phil-davis deleted the stable10-composer-1 branch February 6, 2018 09:17
@lock
Copy link
Copy Markdown

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants