Skip to content

Bump latest symfony and sabre/vobject point versions#29977

Merged
DeepDiver1975 merged 2 commits intomasterfrom
composer-1
Jan 11, 2018
Merged

Bump latest symfony and sabre/vobject point versions#29977
DeepDiver1975 merged 2 commits intomasterfrom
composer-1

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis commented Dec 27, 2017

Description

  1. Do composer update and it bumps symfony and sabre/vobject point versions
  2. Change the mentions of Sabre VObject 4.1.* in tests to the current 4.1.4

Related Issue

Motivation and Context

Other PRs that bump things with composer are also finding these point version changes of other stuff - so get them into core.

How Has This Been Tested?

CI knows

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis phil-davis added this to the development milestone Dec 27, 2017
@phil-davis phil-davis self-assigned this Dec 27, 2017
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 27, 2017 •
edited
Loading

Codecov Report

Merging #29977 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29977      +/-   ##
============================================
- Coverage     58.22%   58.21%   -0.01%     
+ Complexity    18516    18512       -4     
============================================
  Files          1093     1093              
  Lines         63705    63693      -12     
============================================
- Hits          37090    37082       -8     
+ Misses        26615    26611       -4
Impacted Files Coverage Δ Complexity Δ
...amework/Middleware/Security/SecurityMiddleware.php 97.87% <0%> (-0.31%) 16% <0%> (-3%)
drone/src/core/templates/login.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
drone/src/core/Controller/LoginController.php 92.63% <0%> (+1.9%) 36% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc7b1a...cef18e2. Read the comment docs.

@phil-davis phil-davis changed the title Composer 1 Bump latest symfony and sabre/vobject point versions Dec 27, 2017
@DeepDiver1975 DeepDiver1975 merged commit d62d6a4 into master Jan 11, 2018
@DeepDiver1975 DeepDiver1975 deleted the composer-1 branch January 11, 2018 10:24
@phil-davis
Copy link
Copy Markdown
Contributor Author

phil-davis commented Jan 11, 2018

@DeepDiver1975 what happens about backporting all these version bumps to stable10?

(they will need to be backported in order to make it easy)

@DeepDiver1975
Copy link
Copy Markdown
Member

DeepDiver1975 commented Jan 11, 2018

the dependabot is running on stable10 as well. I suggest to simply backport this. THX

@phil-davis phil-davis mentioned this pull request Jan 11, 2018
Closed
This was referenced Jan 23, 2018
Merged
Merged
@phil-davis
Copy link
Copy Markdown
Contributor Author

phil-davis commented Feb 9, 2018

Backport stable10 #30266

@lock
Copy link
Copy Markdown

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

Assignees

@phil-davis phil-davis

Labels

3 - To Review

Projects

None yet

Milestone

10.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@phil-davis @DeepDiver1975 @ownclouders