Fix mimetype detection inside hidden folders #26138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please review @VicDeo @DeepDiver1975 @jvillafanez |
Contributor
Author
|
@owncloud/filesystem |
Member
|
tested 👍 |
Member
|
jenkins is green -> merge |
DeepDiver1975
pushed a commit
that referenced
this pull request
Sep 19, 2016
DeepDiver1975
pushed a commit
that referenced
this pull request
Sep 19, 2016
DeepDiver1975
pushed a commit
that referenced
this pull request
Sep 19, 2016
DeepDiver1975
added a commit
that referenced
this pull request
Sep 20, 2016
DeepDiver1975
added a commit
that referenced
this pull request
Sep 20, 2016
DeepDiver1975
added a commit
that referenced
this pull request
Sep 20, 2016
LukasReschke
pushed a commit
to nextcloud/server
that referenced
this pull request
Sep 26, 2016
Downstreaming of owncloud/core#26138 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix mimetype detection inside hidden folders.
There was a check to find out whether a file name contains a dot, but it was including the whole path instead of just the
basenameso thestrposcall would return 0 and skip detection if the path looks like ".hidden/test.jpg" because of the leading dot.Related Issue
Fixes #26133
Motivation and Context
See issue
How Has This Been Tested?
See steps in issue.
Screenshots (if appropriate):
Types of changes
Checklist:
Backports