Skip to content

Use jsqueeze#19424

Merged
DeepDiver1975 merged 3 commits intomasterfrom
use-jsqueeze
Sep 29, 2015
Merged

Use jsqueeze#19424
DeepDiver1975 merged 3 commits intomasterfrom
use-jsqueeze

Conversation

@DeepDiver1975
Copy link
Copy Markdown
Member

@DeepDiver1975 DeepDiver1975 commented Sep 28, 2015

@DeepDiver1975 DeepDiver1975 added this to the 8.2-current milestone Sep 28, 2015
@DeepDiver1975 DeepDiver1975 mentioned this pull request Sep 28, 2015
Closed
@DeepDiver1975
Copy link
Copy Markdown
Member Author

DeepDiver1975 commented Sep 28, 2015

Please review and test @rperezb @MorrisJobke @LukasReschke @icewind1991 THX

@MorrisJobke
Copy link
Copy Markdown
Contributor

MorrisJobke commented Sep 29, 2015

Tested and works. Also fine with alreay enabled asset pipelining. 👍

@LukasReschke
Copy link
Copy Markdown
Member

LukasReschke commented Sep 29, 2015

👍

@DeepDiver1975
Copy link
Copy Markdown
Member Author

DeepDiver1975 commented Sep 29, 2015

3rdparty submodule updated after merge of owncloud-archive/3rdparty#199

DeepDiver1975 added a commit that referenced this pull request Sep 29, 2015
@DeepDiver1975
Merge pull request #19424 from owncloud/use-jsqueeze
c2dd0f8 
Use jsqueeze
@DeepDiver1975 DeepDiver1975 merged commit c2dd0f8 into master Sep 29, 2015
@DeepDiver1975 DeepDiver1975 deleted the use-jsqueeze branch September 29, 2015 11:44
@SergioBertolinSG
Copy link
Copy Markdown
Contributor

SergioBertolinSG commented Oct 7, 2015

How can we test this besides checking that the interface is not broken?
cc @owncloud/qa

@DeepDiver1975
Copy link
Copy Markdown
Member Author

DeepDiver1975 commented Oct 8, 2015

How can we test this besides checking that the interface is not broken?

monitoring the browser console while loading various pages ... no js error is allowed to pop up

@MorrisJobke
Copy link
Copy Markdown
Contributor

MorrisJobke commented Oct 8, 2015

monitoring the browser console while loading various pages ... no js error is allowed to pop up

While asset-pipeline.enabled is set to true in the config.php

@SergioBertolinSG
Copy link
Copy Markdown
Contributor

SergioBertolinSG commented Oct 9, 2015

Using chrome, no problems found.

Just a recurrent error when opening and closing textfiles, not related I guess.

GET http://HOST/index.php/core/preview.png?file=%2Fnetworkjobs.cpp&c=1444375488&x=32&y=32&forceIcon=0 404 (Not Found)

@MorrisJobke
Copy link
Copy Markdown
Contributor

MorrisJobke commented Oct 9, 2015

Just a recurrent error when opening and closing textfiles, no related I guess.

Yes. Feel free to open a ticket if this is still a reproducable problem

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

4 - To release

Projects

None yet

Milestone

8.2

Development

Successfully merging this pull request may close these issues.

JSMin minifier is non-free (suggest JSqueeze or JShrink as alternatives)

5 participants

@DeepDiver1975 @MorrisJobke @LukasReschke @SergioBertolinSG @PVince81