feat: Add commands to manage DBs in a cloud database service#31
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the cloud database command to cloud database-service to better reflect its purpose of managing database services/clusters, and adds new subcommands under database to manage individual databases within those services.
- Renames
cloud databasetocloud database-servicethroughout the codebase - Adds
databasesubcommands for CRUD operations on databases within a database service - Updates all documentation to reflect the command structure changes
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/services/cloud/cloud_database.go | Adds new struct and functions for database management within services |
| internal/cmd/cloud_database_test.go | Updates test commands to use new database-service naming |
| internal/cmd/cloud_database.go | Restructures commands and adds database subcommands with proper CLI structure |
| doc/*.md | Updates all documentation files to reflect the new command structure and naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ) | ||
|
|
||
| var responseBody map[string]any | ||
| if err := httpLib.Client.Post(endpoint, DatabaseDatabaseSpec, &responseBody); err != nil { |
There was a problem hiding this comment.
The variable DatabaseDatabaseSpec is being passed directly instead of the instance. It should be &cloud.DatabaseDatabaseSpec to pass the actual struct data.
| if err := httpLib.Client.Post(endpoint, DatabaseDatabaseSpec, &responseBody); err != nil { | |
| if err := httpLib.Client.Post(endpoint, &DatabaseDatabaseSpec, &responseBody); err != nil { |
| ## ovhcloud cloud database-service get | ||
|
|
||
| Get a specific database | ||
| Get a specific database services |
There was a problem hiding this comment.
Grammar error: 'services' should be singular 'service' to match the context of getting a specific database service.
| Get a specific database services | |
| Get a specific database service |
Signed-off-by: Arthur Amstutz <arthur.amstutz@corp.ovh.com>
13e60c5 to
b5d245e
Compare
feat: Add commands to manage DBs in a cloud database service
Description
cloud databasetocloud database-serviceType of change
Checklist:
make docgo mod tidy