fix: Player getters getting called correctly for player scope changes#14
Merged
Merged
Conversation
jag3dagster
commented
Jul 28, 2022
Member
- Found this issue with Entered and Left scope events where getting the inScope table was failing to self.source being nil
- While investigating that issue, I also realized that playerData never got removed after a player logged out or left the server
- While figuring out where to nil out playerData entries, I realized that the ox:playerLogout event trigger was attempting to get values from an incorrect object
- While investigating that issue, I also realized that playerData never got removed after a player logged out or left the server
* Found this issue with Entered and Left scope events where getting the inScope table was failing to self.source being nil
* While investigating that issue, I also realized that playerData never got removed after a player logged out or left the server
* While figuring out where to nil out playerData entries, I realized that the ox:playerLogout event trigger was attempting to get values from an incorrect object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.