Support PostgreSQL multi-host connection URIs in DATABASE_URL by Copilot · Pull Request #10754 · outline/outline

Copilot · 2025-11-30T19:11:25Z

The @IsUrl validator from class-validator rejects PostgreSQL multi-host connection URIs (e.g., postgresql://user:pass@host1,host2,host3/db), which are standard for high-availability setups per libpq spec.

Changes

Added isDatabaseUrl validator (server/utils/validators.ts)
- Parses comma-separated hosts with optional ports
- Validates protocol, hostnames, ports (1-65535), query parameters
- Maintains existing options: protocols, require_tld, allow_underscores
Added IsDatabaseUrl decorator (server/utils/validators.ts)
- Drop-in replacement for @IsUrl with class-validator integration
Updated environment validation (server/env.ts)
- Applied to DATABASE_URL, DATABASE_URL_READ_ONLY, DATABASE_CONNECTION_POOL_URL
Test coverage (server/utils/validators.test.ts)
- Single/multi-host URLs, ports, query params, edge cases, invalid inputs

Example

// Now accepts multi-host URIs
DATABASE_URL="postgresql://user:pass@node1.pg18,node2.pg18,node3.pg18,node4.pg18/db?target_session_attrs=read-write"

// Single-host URLs continue to work
DATABASE_URL="postgresql://user:password@localhost:5432/database"

Backward compatible with all existing single-host configurations.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

pkg.pr.new
- Triggering command: /usr/local/bin/node node /usr/local/bin/yarn install (dns block)
- Triggering command: /usr/local/bin/node node /usr/local/bin/yarn install --network-timeout 300000 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Multi-Host DATABASE_URL Rejected</issue_title>
<issue_description>### Is there an existing issue for this?

I have searched the existing issues

This is not related to configuring Outline

~~The issue is not related to self-hosting config~~

Current Behavior

Summary

The application's validation for the DATABASE_URL environment variable rejects standard PostgreSQL connection URIs that include multiple, comma-separated hostnames, even though this is a valid and documented feature of the libpq client for high-availability setups.

The validation error message suggests the URI is not a valid URL, despite conforming to the PostgreSQL connection URI specification for multi-host failover.

Actual Behavior

The application fails during environment validation and refuses to start (or initialize), returning the following error message:
Environment configuration is invalid, please check the following:
- DATABASE_URL must be a URL address
This indicates that the presence of the comma separators within the host component (node1.pg18,node2.pg18,node3.pg18,node4.pg18) is incorrectly failing the application's URL parsing or validation routine.

Expected Behavior

The application should successfully parse the URI. The underlying PostgreSQL client library (libpq or an equivalent driver) is designed to handle multiple hostnames separated by commas in the host section of the URI. The application should attempt to connect to the current primary node among the listed hosts.

Steps To Reproduce

Configure a PostgreSQL cluster with multiple nodes (e.g., using pg_autofailover, resulting in 4 nodes: node1.pg18, node2.pg18, node3.pg18, node4.pg18).

Attempt to set the DATABASE_URL environment variable using a multi-host connection string designed for client-side failover to the primary node:
DATABASE_URL="postgresql://wiki_user:password@node1.pg18,node2.pg18,node3.pg18,node4.pg18/wiki?target_session_attrs=read-write"
Start or initialize the Wiki Outline application.

Environment
- All
Reference

Link to Connection URIs in PostgreSQL documentation.</issue_description>

<agent_instructions>Add a new validator isDatabaseUrl to handle this case in server/utils/validators</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Multi-Host DATABASE_URL Rejected #10749

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>

CLAassistant · 2025-11-30T19:20:02Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [outlinewiki/outline](https://github.com/outline/outline) | minor | `1.1.0` → `1.2.0` | --- ### Release Notes <details> <summary>outline/outline (outlinewiki/outline)</summary> ### [`v1.2.0`](https://github.com/outline/outline/releases/tag/v1.2.0) [Compare Source](outline/outline@v1.1.0...v1.2.0) #### What's Changed ##### Highlights **Diagrams.net** diagrams are now fully supported, insert new diagrams through the block menu or by uploading an existing png that was created in Diagrams.net – the original diagram data will be preserved and can be edited by clicking the "Edit" button in the image toolbar. **Custom emoji** are now available – upload your own custom emoji in the admin settings and use them in your documents, comments, reactions, and icons. **Improved revision history** with the ability to download any revision as HTML or Markdown, toggle whether changes are visible, and an improved rendering engine that retains more of the original document's formatting and structure. **Authentication provider management** has been added to the settings, allowing admins to view and manage all configured authentication providers in one place. This includes the ability to disable providers, which will prevent users from signing in with that provider but will not delete any existing accounts. **Passkey support** has been added as an optional login method. You can now sign in with biometric authentication (TouchId, Windows Hello) or security keys instead of a password. Existing workspaces will need to enable this on the authentication providers screen. ##### Other improvements - The sidebar design was improved and refined in [#10684](outline/outline#10684) - It is now possible to upload and embed PDFs in [#10198](outline/outline#10198) - A "Popular" tab is now available for documents, popular docs are ranked higher in search in [#10721](outline/outline#10721) - A visual color palette is now available in the icon picker in [#10696](outline/outline#10696) - Avatar changes are now synced automatically from iDP in [#10718](outline/outline#10718) - User initials now supported in mention search in [#10797](outline/outline#10797) - New option to distribute table columns evenly in [#10645](outline/outline#10645) - Mermaid diagrams now have an explicit "Edit" option in the toolbar in [#11060](outline/outline#11060) - Added filtering to the notifications UI in [#10916](outline/outline#10916) - Added CSV export for member list in [#10803](outline/outline#10803) - Added CIDR range support to `ALLOWED_PRIVATE_IP_ADDRESSES` in [#10923](outline/outline#10923) - Add ContextMenu to RevisionListItem in [#10952](outline/outline#10952) - The GitHub integration now supports fetching details on public issues/PRs in [#10827](outline/outline#10827) - It is no longer required to use a public bucket for avatar images in [#10977](outline/outline#10977) - Implemented RFC 9700 hardening against refresh token reuse in [#10960](outline/outline#10960) - PKCE OAuth clients can now use refresh tokens in [#10769](outline/outline#10769) - Support for PostgreSQL multi-host connection URIs in `DATABASE_URL` in [#10754](outline/outline#10754) - Many internal performance improvements ##### Fixes - Fixed display issues in share dialog in [#10662](outline/outline#10662) - Incompatibility between path and query search terms in [#10667](outline/outline#10667) - Restored ability to resize shared sidebar in [#10669](outline/outline#10669) - UI does not update when deleting API key in [#10670](outline/outline#10670) - Invalid access of `firstChild` for mermaid diagrams in [#10668](outline/outline#10668) - Plain text copy-to-clipboard serializer no longer squashes blocks in [#10683](outline/outline#10683) - When TOC extends beyond window bounds ensure headings scroll in [#10687](outline/outline#10687) - Added missing drop cursor in top position in [#10689](outline/outline#10689) - `Empty trash` button is now hidden when missing permissions in [#10704](outline/outline#10704) - Fixed search popover on public pages in [#10717](outline/outline#10717) - Multiple improvements to sitemap generation for public shares in [#10716](outline/outline#10716) - Fixed in-document find fails with multiple escaped characters in [#10735](outline/outline#10735) - Improved validation of urls extracted from data transfer event in [#10740](outline/outline#10740) - Middle-mouse button on internal link in Firefox no longer opens multiple tabs in [#10748](outline/outline#10748) - Fixed collection filter returning documents from all collections when no search query in [#10775](outline/outline#10775) - Templates are now inserted at cursor position instead of document start in [#10783](outline/outline#10783) - Shift paste with selection no longer inserts next to selection in [#10799](outline/outline#10799) - Fixed an issue where some Mermaid diagrams can't be expanded in [#10807](outline/outline#10807) - Collection overview now respects the separeat editing mode setting in [#10816](outline/outline#10816) - Query strings not forwarded on internal links from editor in [#10854](outline/outline#10854) - Shutdown during migrations does not release mutex lock in [#10879](outline/outline#10879) - `profileId` extraction in OIDC does not fallback to `token.sub` in [#10882](outline/outline#10882) - Fixed an issue where custom rate limiters were ignored due to mountPath mismatch in [#10893](outline/outline#10893) - Viewer role now replaced correctly on downgrade to guest in [#10877](outline/outline#10877) - Validation of `SECRET_KEY` environment variable tightened in [#10897](outline/outline#10897) - Fixed double pagination in `documents.list` and `documents.archived` with `sort=index` in [#10895](outline/outline#10895) - Comment actions now reliably appear in mobile drawer in [#10904](outline/outline#10904) - Fixed extra newlines in pasted code blocks in [#10958](outline/outline#10958) - Parser crash when pasting inline code containing checkboxes by [@hdoo42](https://github.com/hdoo42) in [#10949](outline/outline#10949) - Fixed an issue where context menus could have context menus (menuception) in [#10974](outline/outline#10974) - Fixed invisible email buttons in iOS Mail dark mode in [#10976](outline/outline#10976) - Restored 'Create a doc' item in mention menu in [#10980](outline/outline#10980) - User with "can edit" permission on sub-document can now sort child documents in [#10990](outline/outline#10990) - Large base64 images pasted as HTML are now correctly handled in [#10982](outline/outline#10982) - Appending content via API no longer messes with existing document content in [#10998](outline/outline#10998) - Image warp exiting lightbox now correct in [#10999](outline/outline#10999) - Grips are now positioned correctly adjacent merged table cells in [#11003](outline/outline#11003) - Export no longer link to a non-accessible location for non-admins in [#11070](outline/outline#11070) #### New Contributors - [@nwleedev](https://github.com/nwleedev) made their first contribution in [#10759](outline/outline#10759) - [@hdoo42](https://github.com/hdoo42) made their first contribution in [#10949](outline/outline#10949) **Full Changelog**: <outline/outline@v1.1.0...v1.2.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3075 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Initial plan

97985d2

Copilot AI assigned Copilot and tommoor Nov 30, 2025

Copilot started work on behalf of tommoor November 30, 2025 19:11 View session

Add isDatabaseUrl validator for multi-host PostgreSQL URIs

bffc3d2

Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix validation for multi-host DATABASE_URL~~ Support PostgreSQL multi-host connection URIs in DATABASE_URL Nov 30, 2025

Copilot AI requested a review from tommoor November 30, 2025 19:26

Copilot finished work on behalf of tommoor November 30, 2025 19:26

tommoor marked this pull request as ready for review November 30, 2025 19:31

Update env.ts

25efcee

tommoor approved these changes Nov 30, 2025

View reviewed changes

tommoor merged commit d75f8d6 into main Dec 1, 2025
13 of 14 checks passed

tommoor deleted the copilot/fix-multi-host-database-url branch December 1, 2025 13:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support PostgreSQL multi-host connection URIs in DATABASE_URL#10754

Support PostgreSQL multi-host connection URIs in DATABASE_URL#10754
tommoor merged 3 commits into
mainfrom
copilot/fix-multi-host-database-url

Copilot AI commented Nov 30, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Nov 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Example

I tried to connect to the following addresses, but was blocked by firewall rules:

This is not related to configuring Outline

Current Behavior

Summary

Actual Behavior

Expected Behavior

Steps To Reproduce

Environment

Reference

Comments on the Issue (you are @copilot in this section)

Uh oh!

CLAassistant commented Nov 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 30, 2025 •

edited

Loading