RTC: Fix null pointer crash in RTC2RTMP when start packet is missing. v6.0.175#4451
Merged
winlinvip merged 3 commits intoossrs:6.0releasefrom Aug 26, 2025
Merged
Conversation
This bug only exist in 5.0 and 6.0, the develop or 7.0 already has its own solution.
winlinvip
approved these changes
Aug 26, 2025
winlinvip
added a commit
that referenced
this pull request
Aug 26, 2025
… v6.0.175 v7.0.63 (#4451) Try to fix #4450 The SRS transcode rtp packets, whose sequence number in range [start, end], to one rtmp packet, but when the first rtp packet is empty, then this crash happens. check #4450 for details. 5.0release and 6.0release branch. develop branch already has its own solution. So this PR is targeting to **6.0release**. find the first not empty rtp packet in seq range [start, end]. --------- Co-authored-by: OSSRS-AI <winlinam@gmail.com> Co-authored-by: winlin <winlinvip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #4450
Cause
The SRS transcode rtp packets, whose sequence number in range [start, end], to one rtmp packet, but when the first rtp packet is empty, then this crash happens.
check #4450 for details.
Impact
5.0release and 6.0release branch.
develop branch already has its own solution.
So this PR is targeting to 6.0release.
Solution
find the first not empty rtp packet in seq range [start, end].