Fix #3767: RTMP: Do not response empty data packet. v6.0.153 v7.0.12#4162
Merged
winlinvip merged 3 commits intoossrs:developfrom Aug 31, 2024
Merged
Fix #3767: RTMP: Do not response empty data packet. v6.0.153 v7.0.12#4162winlinvip merged 3 commits intoossrs:developfrom
winlinvip merged 3 commits intoossrs:developfrom
Conversation
winlinvip
added a commit
that referenced
this pull request
Aug 31, 2024
If SRS responds with this empty data packet, FFmpeg will receive an empty stream, like `Stream #0:0: Data: none` in following logs: ```bash ffmpeg -i rtmp://localhost:11935/live/livestream ``` This won't cause the player to fail, but it will inconvenience the user significantly. It may also cause FFmpeg slower to analysis the stream, see #3767 --------- Co-authored-by: Jacob Su <suzp1984@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If SRS responds with this empty data packet, FFmpeg will receive an empty stream, like
Stream #0:0: Data: nonein following logs:This won't cause the player to fail, but it will inconvenience the user significantly. It may also cause FFmpeg slower to analysis the stream, see #3767
Co-authored-by: Jacob Su suzp1984@gmail.com