RTMP: Do not response publish start message if hooks fail. v5.0.212 v6.0.123#4038
Merged
winlinvip merged 3 commits intoossrs:developfrom Apr 23, 2024
Merged
Conversation
34d070d to
2f035e1
Compare
winlinvip
added a commit
that referenced
this pull request
Apr 23, 2024
…4038) Fix #4037 SRS should not send the publish start message `onStatus(NetStream.Publish.Start)` if hooks fail, which causes OBS to repeatedly reconnect. Note that this fix does not send an RTMP error message when publishing fails, because neither OBS nor FFmpeg process this specific error message; they only display a general error. Apart from the order of messages, nothing else has been changed. Previously, we sent the publish start message `onStatus(NetStream.Publish.Start)` before the HTTP hook `on_publish`; now, we have modified it to send this message after the HTTP hook.
winlinvip
added a commit
to winlinvip/srs
that referenced
this pull request
Jun 13, 2024
….0.212 v6.0.123 (ossrs#4038)" This reverts commit 37f0faa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4037 SRS should not send the publish start message
onStatus(NetStream.Publish.Start)if hooks fail, which causes OBS to repeatedly reconnect.Note that this fix does not send an RTMP error message when publishing fails, because neither OBS nor FFmpeg process this specific error message; they only display a general error.
Apart from the order of messages, nothing else has been changed. Previously, we sent the publish start message
onStatus(NetStream.Publish.Start)before the HTTP hookon_publish; now, we have modified it to send this message after the HTTP hook.