Skip to content

WHIP: Fix bug for converting WHIP to RTMP/HLS. v5.0.208 v6.0.113#3920

Merged
xiaozhihong merged 9 commits intoossrs:developfrom
winlinvip:bugfix/obs-whip
Feb 6, 2024
Merged

WHIP: Fix bug for converting WHIP to RTMP/HLS. v5.0.208 v6.0.113#3920
xiaozhihong merged 9 commits intoossrs:developfrom
winlinvip:bugfix/obs-whip

Conversation

@winlinvip
Copy link
Copy Markdown
Member

@winlinvip winlinvip commented Dec 30, 2023

  1. When converting RTC to RTMP, it is necessary to synchronize the audio and video timestamps. When the synchronization status changes, whether it is unsynchronized or synchronized, print logs to facilitate troubleshooting of such issues.
  2. Chrome uses the STAP-A packet, which means a single RTP packet contains SPS/PPS information. OBS WHIP, on the other hand, sends SPS and PPS in separate RTP packets. Therefore, SPS and PPS are in two independent RTP packets, and SRS needs to cache these two packets.

Co-authored-by: john hondaxiao@tencent.com

@winlinvip
Copy link
Copy Markdown
Member Author

Test the WHIP+WHEP, and WHIP+FLV, all work very well.

image

image

@winlinvip
Copy link
Copy Markdown
Member Author

Need to merge to SRS 5.0 and 6.0 @xiaozhihong

@xiaozhihong xiaozhihong changed the title WHIP: Fix bug for converting WHIP to RTMP/HLS. WHIP: Fix bug for converting WHIP to RTMP/HLS. v5.0.208 v6.0.113 Feb 6, 2024
@xiaozhihong xiaozhihong added the RefinedByAI Refined by AI/GPT. label Feb 6, 2024
@xiaozhihong xiaozhihong merged commit 7209b73 into ossrs:develop Feb 6, 2024
xiaozhihong added a commit that referenced this pull request Feb 6, 2024
1. When converting RTC to RTMP, it is necessary to synchronize the audio
and video timestamps. When the synchronization status changes, whether
it is unsynchronized or synchronized, print logs to facilitate
troubleshooting of such issues.
2. Chrome uses the STAP-A packet, which means a single RTP packet
contains SPS/PPS information. OBS WHIP, on the other hand, sends SPS and
PPS in separate RTP packets. Therefore, SPS and PPS are in two
independent RTP packets, and SRS needs to cache these two packets.

---------

Co-authored-by: john <hondaxiao@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EnglishNative This issue is conveyed exclusively in English. RefinedByAI Refined by AI/GPT.

Development

Successfully merging this pull request may close these issues.

2 participants