SrsContextId assignment can be improved without create a duplicated one. v5.0.175 v6.0.70#3503
Merged
winlinvip merged 3 commits intoossrs:developfrom Aug 28, 2023
Conversation
87f57bc to
4987cd6
Compare
xiaozhihong
approved these changes
Aug 7, 2023
6c88cf8 to
132ae1d
Compare
winlinvip
pushed a commit
that referenced
this pull request
Aug 28, 2023
…ne. v5.0.175 (#3503) SrsContextId object creation can be improved on `srs_protocol_log.cpp`, No need to create one, then assign it back. It seems a common mistake for Cpp programmers. --------- Co-authored-by: john <hondaxiao@tencent.com>
duiniuluantanqin
pushed a commit
to duiniuluantanqin/srs
that referenced
this pull request
Sep 14, 2023
…ne. v5.0.175 (ossrs#3503) SrsContextId object creation can be improved on `srs_protocol_log.cpp`, No need to create one, then assign it back. It seems a common mistake for Cpp programmers. --------- Co-authored-by: john <hondaxiao@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SrsContextId object creation can be improved on
srs_protocol_log.cpp, No need to create one, then assign it back. It seems a common mistake for Cpp programmers.Co-authored-by: john hondaxiao@tencent.com