FLV: Drop packet if header flag is not matched. v5.0.109#3306
Merged
winlinvip merged 2 commits intoossrs:5.0releasefrom Dec 14, 2022
Merged
FLV: Drop packet if header flag is not matched. v5.0.109#3306winlinvip merged 2 commits intoossrs:5.0releasefrom
winlinvip merged 2 commits intoossrs:5.0releasefrom
Conversation
Member
winlinvip
commented
Dec 13, 2022
- Ignore audo or video packets if FLV header disable it.
- Reset has_audio if got some video frames but no audio frames.
- Reset has_video if got some audio frames but no video frames.
- Note that audio/video frames are not sequence header.
xiaozhihong
reviewed
Dec 14, 2022
winlinvip
commented
Dec 14, 2022
1. Ignore audo or video packets if FLV header disable it. 2. Run: Add regression test config and run for IDEA. 3. Test: Refine regression test to allow no audio/video for FLV 4. Config: Whether drop packet if not match header.
454c10d to
ac06d35
Compare
xiaozhihong
approved these changes
Dec 14, 2022
winlinvip
added a commit
that referenced
this pull request
Dec 18, 2022
1. SRT: Fix srt to rtmp crash when sps or pps empty. v5.0.112 (#3323) 2. GB28181: Fix memory overlap for small packets. v5.0.111 (#3315) 3. FLV: Support set default has_av and disable guessing. v5.0.110 (#3311) 4. FLV: Drop packet if header flag is not matched. v5.0.109 (#3306) 5. FLV: Reset has_audio or has_video if only sequence header. (#3310)
winlinvip
added a commit
that referenced
this pull request
Dec 18, 2022
1. SRT: Fix srt to rtmp crash when sps or pps empty. v5.0.112 (#3323) 2. GB28181: Fix memory overlap for small packets. v5.0.111 (#3315) 3. FLV: Support set default has_av and disable guessing. v5.0.110 (#3311) 4. FLV: Drop packet if header flag is not matched. v5.0.109 (#3306) 5. FLV: Reset has_audio or has_video if only sequence header. (#3310)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.