API: Support statistic and on_play/stop for HLS stream#2578
API: Support statistic and on_play/stop for HLS stream#2578winlinvip merged 4 commits intoossrs:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2578 +/- ##
===========================================
+ Coverage 59.14% 60.61% +1.47%
===========================================
Files 122 122
Lines 51759 55103 +3344
===========================================
+ Hits 30613 33403 +2790
- Misses 21146 21700 +554 | Impacted Files | Coverage Δ | |' Translated to English while maintaining the markdown structure: '| Impacted Files | Coverage Δ | | Translated to English while maintaining the markdown structure: '| trunk/src/app/srs_app_http_api.cpp | Translated to English while maintaining the markdown structure: '| trunk/src/app/srs_app_dvr.cpp | Continue to review full report at Codecov.
Translated to English while maintaining the markdown structure: |
|
| #include <srs_app_http_hooks.hpp> | ||
| #include <srs_app_statistic.hpp> | ||
|
|
||
| #define SRS_SECRET_IN_HLS "srs_secret" |
There was a problem hiding this comment.
secret' feels like it would be better to change the name. My first reaction is always "key"... If you don't look closely, you might think this is some kind of authentication code. Maybe changing it to 'userid', 'uniqueid', or 'magicid' would be better?
TRANS_BY_GPT3
663863e to
edce854
Compare
…2578) * Enhance HLS: support http callback on_play/stop, support statistic * make code readable * make code readable * rename secret
No description provided.